Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison logic for P3A question Brave.P3A.SentAnswersCount #4145

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

bsclifton
Copy link
Member

Found this while reviewing with @GeetaSarvadnya

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton self-assigned this Dec 5, 2019
@bsclifton bsclifton added this to the 1.4.x - Nightly milestone Dec 6, 2019
@bsclifton bsclifton merged commit aa21b90 into master Dec 6, 2019
@bsclifton bsclifton deleted the bsc-p3a-sent-answer-count-fix branch December 6, 2019 07:22
bsclifton added a commit that referenced this pull request Dec 6, 2019
Fix comparison logic for P3A question Brave.P3A.SentAnswersCount
bsclifton added a commit that referenced this pull request Dec 6, 2019
Fix comparison logic for P3A question Brave.P3A.SentAnswersCount
bsclifton added a commit that referenced this pull request Dec 6, 2019
Fix comparison logic for P3A question Brave.P3A.SentAnswersCount
@bsclifton
Copy link
Member Author

1.3 e9f0f92
1.2 06094fb
1.1 1be2459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants