Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add listener for brave://settings/privacy to ensure P3A enabled value is in sync #4185

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Add listener for brave://settings/privacy to ensure P3A enabled value is in sync #4185

merged 2 commits into from
Dec 10, 2019

Commits on Dec 9, 2019

  1. Add listener for brave://settings/privacy to ensure P3A enabled value… 

    … is in sync

For example, if you had two windows with brave://settings/privacy open

Fixes brave/brave-browser#7289

This is something I missed while implementing #3242
    @bsclifton
    bsclifton committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    d056a21 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Put P3A items on privacy page behind BRAVE_P3A_ENABLED guard

    @bsclifton
    bsclifton committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    ae9bf83 View commit details
    Browse the repository at this point in the history