Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes illegal (non-ascii) char in release description text (upload.py) #438

Merged
merged 1 commit into from
Sep 12, 2018
Merged

fixes illegal (non-ascii) char in release description text (upload.py) #438

merged 1 commit into from
Sep 12, 2018

Conversation

mihaiplesa
Copy link
Collaborator

fixes illegal (non-ascii) char in release description text (upload.py)

fixes brave/brave-browser#954

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mihaiplesa mihaiplesa self-assigned this Sep 12, 2018
mbacchi
mbacchi approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mbacchi mbacchi merged commit c244022 into master Sep 12, 2018
mbacchi added a commit that referenced this pull request Sep 12, 2018
@mbacchi
Merge pull request #438 from brave/fix-char-inrelease-description-text
ff711e5 
fixes illegal (non-ascii) char in release description text (upload.py)
@bbondy
Copy link
Member

bbondy commented Sep 12, 2018

0.55.x ff711e5

@bsclifton bsclifton deleted the fix-char-inrelease-description-text branch September 26, 2018 05:44
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #438 from brave/67.0.3396.103
70bafa0 
Update to Chromium 67.0.3396.103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbacchi mbacchi mbacchi approved these changes

Assignees

@mihaiplesa mihaiplesa

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Update release description text in upload.py
3 participants
@mihaiplesa @bbondy @mbacchi