Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes illegal (non-ascii) char in release description text (upload.py) #438

Merged
merged 1 commit into from
Sep 12, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def get_text_with_editor(name):
def create_release_draft(repo, tag):
name = '{0} {1}'.format(release_name(), tag)
# TODO: Parse release notes from CHANGELOG.md
body = '''*This is not the released version of Brave. **Be careful** things are unstable and might even be broken.*
body = '''*This is not the released version of Brave. **Be careful** - things are unstable and might even be broken.*

These builds are an unpolished and unfinished early preview for the new version of Brave on the desktop. These builds show our work in progress and they aren't for the faint-of-heart. Features may be missing or broken in new and exciting ways; familiar functionality may have unfamiliar side-effects. These builds showcase the newest advances that we're bringing to your browser, but this is still a prototype, not a reliable daily driver. Try it out only if you're looking for a little extra spice and adventure in your browsing.

Expand Down