Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MIT license for crypto-icons font #5332

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Adding MIT license for crypto-icons font #5332

merged 1 commit into from
Apr 23, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 23, 2020

Fixes: brave/brave-browser#9407

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added the CI/skip Do not run CI builds (except noplatform) label Apr 23, 2020
@ryanml ryanml added this to the 1.10.x - Nightly milestone Apr 23, 2020
@ryanml ryanml requested review from fmarier and bbondy April 23, 2020 03:02
@ryanml ryanml self-assigned this Apr 23, 2020
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

If you want to test it, run npm run create_dist and then search for crypto-icons in brave://credits.

@ryanml ryanml merged commit 807fa74 into master Apr 23, 2020
@ryanml ryanml deleted the fix-9407 branch April 23, 2020 16:45
ryanml added a commit that referenced this pull request Apr 23, 2020
Adding MIT license for crypto-icons font
bsclifton pushed a commit that referenced this pull request Apr 24, 2020
Adding MIT license for crypto-icons font
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave | 1.10.9 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-04-24 at 4 23 13 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing license for crypto/coins.ttf
3 participants