Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed top toolbar with disabled bottom toolbar and no rewards icon #5412

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Apr 28, 2020

Resolves brave/brave-browser#9040

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 28, 2020
@samartnik samartnik added this to the 1.10.x - Nightly milestone Apr 28, 2020
@samartnik samartnik self-assigned this Apr 28, 2020
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik
Copy link
Contributor Author

Build failed on tests, not related to this PR

@samartnik samartnik merged commit 0ea57ed into master Apr 29, 2020
@samartnik samartnik deleted the android_fixed_disabled_bottom_toolbar_no_rewards branch April 29, 2020 19:57
brave-builds pushed a commit that referenced this pull request Apr 29, 2020
brave-builds pushed a commit that referenced this pull request Apr 29, 2020
@srirambv
Copy link
Contributor

srirambv commented May 4, 2020

Verification passed on OnePlus 6T with Android 10 running 1.10.22 x64 nightly build

  • Verified Tab count is not part of the URL bar any more when the bottom toolbar is disabled
    image

samartnik pushed a commit that referenced this pull request May 4, 2020
samartnik pushed a commit that referenced this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] URL is shown behind tab count on private tab when bottom toolbar is disabled
4 participants