-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds desktop process in sandbox #5894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@NejcZdovc It was needed for linux&windows to work, otherwise it would fail when trying to use |
changing this to draft as like @yrliou pointed out this is still a problem on linux https://ci.brave.com/job/pr-brave-browser-desktop-sandbox/2/execution/node/432/log/. When we implement brave/brave-browser#8428 we will remove last piece of anonize and we can merge this one |
b004c08
to
0243da7
Compare
brave/brave-browser#8428 is merged now, so this should work now |
CI failed on linux, restarting |
0243da7
to
037c51c
Compare
037c51c
to
c2b3fb2
Compare
Resolves brave/brave-browser#10356
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
NA
Reviewer Checklist:
After-merge Checklist:
changes has landed on.