Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds desktop process in sandbox #5894

Closed
wants to merge 1 commit into from
Closed

Adds desktop process in sandbox #5894

wants to merge 1 commit into from

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 18, 2020

Resolves brave/brave-browser#10356

Submitter Checklist:

Test Plan:

NA

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added feature/rewards CI/skip-ios Do not run CI builds for iOS labels Jun 18, 2020
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 18, 2020
@NejcZdovc NejcZdovc requested a review from a team June 18, 2020 11:56
@NejcZdovc NejcZdovc self-assigned this Jun 18, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team June 18, 2020 11:56
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yrliou
Copy link
Member

yrliou commented Jun 18, 2020

@NejcZdovc It was needed for linux&windows to work, otherwise it would fail when trying to use bat-native-anonize, is this no longer the case? Maybe it isn't the case anymore, but just to be safe, could you test and double check on platforms other than macOS?

@NejcZdovc NejcZdovc marked this pull request as draft June 19, 2020 05:53
@NejcZdovc
Copy link
Contributor Author

changing this to draft as like @yrliou pointed out this is still a problem on linux https://ci.brave.com/job/pr-brave-browser-desktop-sandbox/2/execution/node/432/log/. When we implement brave/brave-browser#8428 we will remove last piece of anonize and we can merge this one

@NejcZdovc NejcZdovc removed this from the 1.12.x - Nightly milestone Jun 19, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review July 28, 2020 06:10
@NejcZdovc
Copy link
Contributor Author

brave/brave-browser#8428 is merged now, so this should work now

@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Jul 29, 2020
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Jul 29, 2020
@NejcZdovc
Copy link
Contributor Author

CI failed on linux, restarting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Add sandbox for desktop for ledger mojo service
3 participants