Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new persona creation #8428

Closed
NejcZdovc opened this issue Feb 27, 2020 · 4 comments · Fixed by brave/brave-core#6000
Closed

Implement new persona creation #8428

NejcZdovc opened this issue Feb 27, 2020 · 4 comments · Fixed by brave/brave-core#6000

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 27, 2020

Right now when we call api server creates paymentId and wallets etc. New api should just crate payment Id and that is it. We will also remove anonize dependency with this move. As part of this effort we will also implement new settings api (#9132).

@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 16, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 21, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 24, 2020
@NejcZdovc NejcZdovc added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 10, 2020
@LaurenWags
Copy link
Member

Marked as QA/Blocked pending additional test plan information (requested from @NejcZdovc )

@LaurenWags
Copy link
Member

Confirmed additional areas outside of test plan are not required for specifically testing this issue, thanks @NejcZdovc !

@LaurenWags
Copy link
Member

LaurenWags commented Aug 17, 2020

Verified using

Brave | 1.13.73 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.14.6 (Build 18G3020)

Confirmed plan 1 from brave/brave-core#6000 when enabling Rewards via panel, NTP widget, and brave://rewards page. Confirmed that in Preference file that brave.rewards.wallet has payment_id and seed populated.

Confirmed plan 2 from brave/brave-core#6000. Confirmed able to restore a wallet by manually copy/paste of words and import of backup file. Both were successful. Encountered #11235 while testing.
Screen Shot 2020-08-17 at 3 46 54 PM

Confirmed plan 3 from brave/brave-core#6000. Confirmed migration message displayed. Link in message directs user to https://brave.com/faq/#convert-old-keys.
Screen Shot 2020-08-17 at 3 50 47 PM

Plan 4 from brave/brave-core#6000 failed. ed follow-up issue #11298.


Verification passed on


Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


Confirmed plan 1 from brave/brave-core#6000 when enabling Rewards via panel, NTP widget, and brave://rewards page. Confirmed that in Preference file that brave.rewards.wallet has payment_id and seed populated.

Confirmed plan 2 from brave/brave-core#6000. Confirmed able to restore a wallet by manually copy/paste of words and import of backup file. Both were successful. Encountered #11235 while testing.

image

Confirmed plan 3 from brave/brave-core#6000. Confirmed migration message displayed. Link in message directs user to https://brave.com/faq/#convert-old-keys.
image

plan 4: Encountered #11298


Verification passed on

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

Confirmed plan 1 from brave/brave-core#6000 when enabling Rewards via panel, NTP widget, and brave://rewards page. Confirmed that in Preference file that brave.rewards.wallet has payment_id and seed populated.

Confirmed plan 2 from brave/brave-core#6000. Confirmed able to restore a wallet by manually copy/paste of words and import of backup file. Both were successful. Encountered #11235.
image

Confirmed plan 3 from brave/brave-core#6000. Confirmed migration message displayed. Link in message directs user to https://brave.com/faq/#convert-old-keys.
image

plan 4: Encountered #11298

@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.84 x64 build

  • Verified wallet is created automatically when rewards is enabled
  • Verified importing wallet key restores the wallet correctly
  • Verified entering random 16 words in restore wallet doesn't restore any wallet

Verification passed on Samsung Tab A with Android 10 running 1.13.84 x64 build

  • Verified wallet is created automatically when rewards is enabled
  • Verified importing wallet key restores the wallet correctly
  • Verified entering random 16 words in restore wallet doesn't restore any wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants