Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Chromium from 70.0.3538.35 to 70.0.3538.45 #1426

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Upgrade Chromium from 70.0.3538.35 to 70.0.3538.45 #1426

merged 1 commit into from
Oct 5, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 4, 2018 •
edited
Loading

Fix #1425

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy changed the title WIP: Upgrade Chromium from 70.0.3538.35 to 70.0.3538.45 Upgrade Chromium from 70.0.3538.35 to 70.0.3538.45 Oct 5, 2018
@bbondy bbondy requested a review from emerick October 5, 2018 15:48
emerick
emerick approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 3aa1727 into master Oct 5, 2018
bbondy added a commit that referenced this pull request Oct 5, 2018
@bbondy
Merge pull request #1426 from brave/70.0.3538.45
f572172 
Upgrade Chromium from 70.0.3538.35 to 70.0.3538.45
bbondy added a commit that referenced this pull request Oct 5, 2018
@bbondy
Merge pull request #1426 from brave/70.0.3538.45
1556d30 
Upgrade Chromium from 70.0.3538.35 to 70.0.3538.45
@bbondy
Copy link
Member Author

bbondy commented Oct 5, 2018

master: 3aa1727
0.56.x: f572172
0.55.x: 1556d30

@bbondy bbondy self-assigned this Oct 5, 2018
@bbondy bbondy deleted the 70.0.3538.45 branch October 14, 2018 14:40
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
This was referenced Aug 17, 2020
Open
Closed
@LaurenWags LaurenWags mentioned this pull request Aug 18, 2020
Closed
@srirambv srirambv mentioned this pull request Aug 19, 2020
Closed
@LaurenWags LaurenWags mentioned this pull request Aug 20, 2020
Closed
This was referenced Aug 20, 2020
Closed
Closed
Closed
@btlechowski btlechowski mentioned this pull request Aug 20, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Aug 20, 2020
Closed
@LaurenWags LaurenWags mentioned this pull request Aug 20, 2020
Closed
@btlechowski btlechowski mentioned this pull request Aug 20, 2020
Closed
This was referenced Aug 20, 2020
Closed
Closed
@srirambv srirambv mentioned this pull request Aug 21, 2020
Closed
This was referenced Aug 21, 2020
Closed
Closed
This was referenced Aug 21, 2020
Closed
Closed
This was referenced Aug 21, 2020
Closed
Closed
Closed
Closed
Closed
@btlechowski btlechowski mentioned this pull request Aug 21, 2020
Closed
This was referenced Aug 21, 2020
Closed
Closed
Closed
Alcoholonline
Alcoholonline reviewed Aug 24, 2020
View reviewed changes
Copy link

@Alcoholonline Alcoholonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heroinonline@hotmail.com

@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Aug 25, 2020
Closed
This was referenced Aug 25, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcoholonline Alcoholonline Alcoholonline left review comments

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@bbondy @emerick @Alcoholonline