Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Migrate uphold_anon_address into external_wallets.uphold #10397

Closed
NejcZdovc opened this issue Jun 22, 2020 · 1 comment · Fixed by brave/brave-core#6063
Closed

Comments

@NejcZdovc
Copy link
Contributor

Right now uphold_anon_address lives in brave.rewards and we don't clear it when we disconnecting wallet. This should be migrated into brave.rewards.external_wallets.uphold, so that when we disconnect wallet we remove everything.

When migration is done we should clear and deprecate kStateUpholdAnonAddress value.

@LaurenWags
Copy link
Member

LaurenWags commented Aug 18, 2020

Verified passed with

Brave	1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.14.6 (Build 18G3020)

Plan 1 from brave/brave-core#6063
Prior to connecting KYC'd uphold wallet, this is what Preferences file looked like:
prefs ss 1

After connecting KYC'd uphold wallet, this is what Preferences file looked like:
prefs ss 2

Plan 2 from brave/brave-core#6063
Using 1.12.x, this is what Preferences file looked like with KYC'd wallet:
prefs ss 3

Upgrading to 1.13.x, this is what the Preferences file looked like:
prefs ss 4
prefs ss 5


Verification passed on

Brave | 1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Plan 1 from brave/brave-core#6063
Prior to connecting KYC'd uphold wallet, this is what Preferences file looked like:
image

After connecting KYC'd uphold wallet, this is what Preferences file looked like:
image

Plan 2 from brave/brave-core#6063
Using 1.12.x, this is what Preferences file looked like with KYC'd wallet:
image

Upgrading to 1.13.x, this is what the Preferences file looked like:
image


Verification passed on

Brave 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

Plan 1 from brave/brave-core#6063

After connecting KYC'd uphold wallet, this is what Preferences file looked like:
image

Plan 2 from brave/brave-core#6063
Using 1.12.x, this is what Preferences file looked like with KYC'd wallet:
image

Upgrading to 1.13.x, this is what the Preferences file looked like:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment