Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates anon address to uphold wallet object #6063

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 13, 2020

Resolves brave/brave-browser#10397

Submitter Checklist:

Test Plan:

plan 1

  • enable rewards
  • connect kyc wallet
  • make sure that you see anon_address filled in uphold object in Preferences file

plan 2

  • start on master
  • enable rewards
  • connect kyc wallet
  • make sure that you see uphold_anon_address in Preferences file
  • close browser
  • switch to this PR and start the browser
  • make sure that you see anon_address filled in uphold object and no more uphold_anon_address in Preferences file

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 13, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 13, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review July 13, 2020 11:59
@NejcZdovc NejcZdovc requested review from a team, emerick and zenparsing and removed request for a team July 13, 2020 12:00
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc
Copy link
Contributor Author

CI failed on test-install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Migrate uphold_anon_address into external_wallets.uphold
3 participants