-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates anon address to uphold wallet object #6063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
migrate-anon-address
branch
from
July 13, 2020 11:22
15a2b84
to
d91c145
Compare
NejcZdovc
force-pushed
the
migrate-anon-address
branch
from
July 13, 2020 11:59
d91c145
to
4aee51d
Compare
NejcZdovc
requested review from
a team,
emerick and
zenparsing
and removed request for
a team
July 13, 2020 12:00
NejcZdovc
commented
Jul 13, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/state/state_migration_v3.cc
Outdated
Show resolved
Hide resolved
emerick
reviewed
Jul 13, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/wallet/wallet.h
Outdated
Show resolved
Hide resolved
zenparsing
reviewed
Jul 13, 2020
emerick
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NejcZdovc
force-pushed
the
migrate-anon-address
branch
from
July 13, 2020 16:07
4aee51d
to
15494f3
Compare
zenparsing
approved these changes
Jul 13, 2020
NejcZdovc
force-pushed
the
migrate-anon-address
branch
from
July 13, 2020 19:05
15494f3
to
ad00322
Compare
NejcZdovc
force-pushed
the
migrate-anon-address
branch
from
July 13, 2020 19:06
ad00322
to
0d3c7af
Compare
CI failed on test-install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#10397
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1
plan 2
uphold_anon_address
in Preferences fileuphold_anon_address
in Preferences fileReviewer Checklist:
After-merge Checklist:
changes has landed on.