Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flow for using refresh tokens (Gemini) #6242

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Adding flow for using refresh tokens (Gemini) #6242

merged 2 commits into from
Jul 30, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 28, 2020

Fixes brave/brave-browser#10978

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.14.x - Nightly milestone Jul 28, 2020
@ryanml ryanml requested review from bbondy and emerick July 28, 2020 23:16
@ryanml ryanml self-assigned this Jul 28, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Jul 30, 2020

Jenkins failure due to unrelated test failures cc: @bbondy

@ryanml ryanml merged commit 15fdf08 into master Jul 30, 2020
@ryanml ryanml deleted the gemini-refresh branch July 30, 2020 21:02
ryanml added a commit that referenced this pull request Jul 30, 2020
Adding flow for using refresh tokens (Gemini)
ryanml added a commit that referenced this pull request Aug 7, 2020
Adding flow for using refresh tokens (Gemini)
ryanml added a commit that referenced this pull request Aug 14, 2020
Adding flow for using refresh tokens (Gemini)
@kjozwiak
Copy link
Member

kjozwiak commented Aug 16, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.44 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.15.6 (Build 19G73)

Screen Shot 2020-08-15 at 9 31 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh token should be used in re-authorization flow (Gemini)
4 participants