Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Oauth scopes for Gemini #6280

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Updates Oauth scopes for Gemini #6280

merged 1 commit into from
Jul 31, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 31, 2020

Fixes brave/brave-browser#11030

Scopes were updated on Gemini's end to be more granular, this doesn't change overall permissions.

Submitter Checklist:

Test Plan:

General widget regression test

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.14.x - Nightly milestone Jul 31, 2020
@ryanml ryanml requested review from bbondy and emerick July 31, 2020 04:03
@ryanml ryanml self-assigned this Jul 31, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 4de9c09 into master Jul 31, 2020
@ryanml ryanml deleted the gemini-scope branch July 31, 2020 19:00
ryanml added a commit that referenced this pull request Aug 1, 2020
Updates Oauth scopes for Gemini
ryanml added a commit that referenced this pull request Aug 7, 2020
Updates Oauth scopes for Gemini
ryanml added a commit that referenced this pull request Aug 14, 2020
Updates Oauth scopes for Gemini
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.42 Chromium: 85.0.4183.59 (Official Build) nightly (64-bit)
-- | --
Revision | 7cc9a5ee672625c38427a839cb1b15efd3128084-refs/branch-heads/4183@{#1216}
OS | macOS Version 10.15.6 (Build 19G73)
Example 1 example2
Screen Shot 2020-08-14 at 8 47 19 PM Screen Shot 2020-08-14 at 8 47 13 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemini widget should use updated trading scopes
4 participants