Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows total amount to be received in a Gemini sell order #6307

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 1, 2020

Fixes brave/brave-browser#11046

Screen Shot 2020-07-31 at 6 07 53 PM
Screen Shot 2020-07-31 at 5 47 53 PM

Submitter Checklist:

Test Plan:

Spec in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.14.x - Nightly milestone Aug 1, 2020
@ryanml ryanml requested review from bbondy and emerick August 1, 2020 01:14
@ryanml ryanml self-assigned this Aug 1, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a couple of minor comments

@ryanml ryanml force-pushed the fix-11046 branch 2 times, most recently from 0505656 to c09d284 Compare August 3, 2020 22:40
@ryanml ryanml merged commit ee9d056 into master Aug 4, 2020
@ryanml ryanml deleted the fix-11046 branch August 4, 2020 02:53
ryanml added a commit that referenced this pull request Aug 4, 2020
Shows total amount to be received in a Gemini sell order
ryanml added a commit that referenced this pull request Aug 7, 2020
Shows total amount to be received in a Gemini sell order
ryanml added a commit that referenced this pull request Aug 14, 2020
Shows total amount to be received in a Gemini sell order
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.44 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.15.6 (Build 19G73)

Screen Shot 2020-08-16 at 3 57 05 AM

Unfortunately I don't have a bank account linked so can't check the buy screen. QA or @ryanml will check the Buy screen once this lands in 1.13.x.

ryanml added a commit that referenced this pull request Aug 17, 2020
Shows total amount to be received in a Gemini sell order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sell panel should include to the total amount to be received in USD (Gemini)
3 participants