Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows total amount to be received in a Gemini sell order (1.13) #6328

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 4, 2020

Uplift of #6307
Resolves brave/brave-browser#11046

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml ryanml added this to the 1.13.x - Beta milestone Aug 4, 2020
@ryanml ryanml requested a review from a team August 4, 2020 02:58
@ryanml ryanml self-assigned this Aug 4, 2020
@ryanml ryanml force-pushed the gemini-sell-1.13 branch 2 times, most recently from 2ed4e2a to 8bb118c Compare August 14, 2020 21:04
@kjozwiak
Copy link
Member

Restarting Android via https://ci.brave.com/job/brave-core-build-pr-android/job/PR-6328/ as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-gemini-sell-1.13-android/1/execution/node/125/log/.

18:14:24  + set -e
18:14:24  + /home/ubuntu/android-sdk/tools/mksdcard -l android29 10240M android.img
18:14:30  + echo no
18:14:30  + /home/ubuntu/android-sdk/tools/bin/avdmanager create avd -f -c android.img -n android-1 -k system-images;android-29;google_apis;x86
18:14:31  Loading local repository...                                                     
[=========                              ] 25% Loading local repository...       
[=========                              ] 25% Fetch remote repository...        
[=========                              ] 25% Fetch remote repository...        
[=========                              ] 25% Fetch remote repository...        
[=======================================] 100% Fetch remote repository...       
Auto-selecting single ABI x86
18:14:31  Do you wish to create a custom hardware profile? [no] Error: AVD not created.
18:14:31  null

@kjozwiak
Copy link
Member

kjozwiak commented Aug 17, 2020

Restarting Linux via https://ci.brave.com/job/brave-core-build-pr-linux/job/PR-6328/5/ as build failed as per https://ci.brave.com/job/pr-brave-browser-gemini-sell-1.13-linux/2/execution/node/169/log/.

14:02:55  FAILED: obj/brave/components/gemini/browser/browser/gemini_service.o 

Restarting macOS via https://ci.brave.com/job/brave-core-build-pr-macos/job/PR-6328/5/ as build failed as per https://ci.brave.com/job/pr-brave-browser-gemini-sell-1.13-macos/2/execution/node/174/log/

14:18:34  FAILED: obj/brave/components/gemini/browser/browser/gemini_service.o 

@ryanml we'll see if the above works after a restart but we might have an issue with ☝️

@kjozwiak
Copy link
Member

kjozwiak commented Aug 17, 2020

Restarting Win x64 via https://ci.brave.com/job/brave-core-build-pr-windows/job/PR-6328/6/ as we lost the spot instance/agent was removed as per https://ci.brave.com/job/pr-brave-browser-gemini-sell-1.13-windows/3/execution/node/169/log/.

16:10:08  Cannot contact i-0fca5ba17f09214de: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
16:15:16  Could not connect to i-0fca5ba17f09214de to send interrupt signal to process

Shows total amount to be received in a Gemini sell order
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6307 (comment).

@kjozwiak kjozwiak merged commit 1e15b1e into 1.13.x Aug 18, 2020
@kjozwiak kjozwiak deleted the gemini-sell-1.13 branch August 18, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants