Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SXG and WebBundles blink experimental features. #6434

Closed
wants to merge 1 commit into from
Closed

Disable SXG and WebBundles blink experimental features. #6434

wants to merge 1 commit into from

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 17, 2020 •
edited
Loading

Fixes brave/brave-browser#11133

  • Modified redirect-cc.py to allow overriding files under out/XXX/gen

  • Overrode getter methods for:

    • SignedExchangePrefetchCacheForNavigations
    • SignedExchangeSubresourcePrefetch
    • SubresourceWebBundles

    to always return false

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.14.x - Nightly milestone Aug 17, 2020
@mkarolin mkarolin self-assigned this Aug 17, 2020
@mkarolin
Disable SXG and WebBundles blink experimental features.
e6de376 
Fixes brave/brave-browser#11133

- Modified redirect-cc.py to allow overriding files under out/XXX/gen
- Overrode getter methods for:
  * SignedExchangePrefetchCacheForNavigations
  * SignedExchangeSubresourcePrefetch
  * SubresourceWebBundles
  to always return `false`
@mkarolin mkarolin force-pushed the maxk-disable-sxg-web-bundles branch from 4b72a92 to e6de376 Compare August 18, 2020 00:30
@mkarolin mkarolin changed the title WIP: Disable SXG and WebBundles blink experimental features. Disable SXG and WebBundles blink experimental features. Aug 18, 2020
pes10k
pes10k approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @mkarolin !

AlexeyBarabash
AlexeyBarabash approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak kjozwiak removed this from the 1.17.x - Release milestone Nov 19, 2020
@kjozwiak
Copy link
Member

Removing this from the 1.17.x as this still hasn't landed in master. Please don't place PRs/issues that are not completed in milestones as per the process via https://github.com/brave/brave-browser/wiki/Triage-Guidelines#milestones-and-issues.

Screen Shot 2020-11-19 at 2 29 03 PM

@mkarolin
Copy link
Collaborator Author

Closing in favor of #6933

@mkarolin mkarolin closed this Nov 25, 2020
@mkarolin mkarolin deleted the maxk-disable-sxg-web-bundles branch September 7, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pes10k pes10k pes10k approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@LUGO022 LUGO022 LUGO022 approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@jumde jumde Awaiting requested review from jumde

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable SXG and WebBundles
5 participants
@mkarolin @kjozwiak @pes10k @AlexeyBarabash @LUGO022