Disables several blink runtime features. #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
2 times, most recently
from
268e53d
to
f003ca2
Compare
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
4 times, most recently
from
d0e7793
to
1b5b6fa
Compare
mkarolin
changed the title
32 tasks
simonhong
reviewed
Nov 26, 2020
chromium_src/third_party/blink/renderer/core/origin_trials/origin_trial_context.cc
Outdated
Show resolved
Hide resolved
simonhong
reviewed
Nov 26, 2020
| return | ||
| rel_path_parts = rel_path.split(os.sep, 3) | ||
| if rel_path_parts[0] in OUT_DIR_NAMES: | ||
| if rel_path_parts[2] == 'gen': |
simonhong
approved these changes
Nov 27, 2020
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
from
47ceb5f
to
76c509d
Compare
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
from
76c509d
to
b0d2a3c
Compare
|
Rebased. |
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
3 times, most recently
from
6a7ef0d
to
efbbadb
Compare
|
Both Linux and Android have lint (format) errors in files that aren't related to this PR. |
|
@bridiver, PTAL when you can. |
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
from
efbbadb
to
ad05f75
Compare
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
2 times, most recently
from
e3b3ae0
to
af3b9ab
Compare
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
from
af3b9ab
to
237664b
Compare
bridiver
reviewed
Jan 27, 2021
| void SetUp() override { InProcessBrowserTest::SetUp(); } | ||
| void SetUp() override { | ||
| // Test that even with Lang CH feature enabled, there is no header. | ||
| scoped_feature_list_.InitAndEnableFeature(features::kLangClientHintHeader); |
There was a problem hiding this comment.
shouldn't we test with this both enabled and disabled?
There was a problem hiding this comment.
Addressed by 296d753
Fixes brave/brave-browser#11133 Fixes brave/brave-browser#11407 Fixes brave/brave-browser#11546 Fixes brave/brave-browser#11547 - Disables features via Chromium features: * Direct Sockets * Lang Client Hint Header * Signed Exchange Prefetch Cache For Navigations * Subresource Web Bundles - Disabled the following blink features in BraveContentRendererClient::SetRuntimeFeaturesDefaultsBeforeBlinkInitialization since they don't have Chromium features: * Digital Goods * Native File System (File System Access) - Added browser tests for these features - Modified redirect-cc.py to allow overriding files under out/XXX/gen - Added an override for blink::origin_trials::IsTrialValid and overrides for blink::OriginTrialContext methods AddFeature and AddForceEnabledTrials for trials: * NativeFileSystem2 * SignedExchangeSubresourcePrefetch * SubresourceWebBundles - Added browser tests for trials disablement.
The parameter flips Lang CH feature enabled/disabled.
mkarolin
force-pushed
the
maxk-disable-sxg-web-bundles-2
branch
from
237664b
to
296d753
Compare
bridiver
approved these changes
Jan 27, 2021
|
Windows CI failure is not related to this PR (certificate issue). |
brave-builds
pushed a commit
that referenced
this pull request
Jan 28, 2021
brave-builds
pushed a commit
that referenced
this pull request
Jan 28, 2021
This was referenced Jan 28, 2021
mkarolin
pushed a commit
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#11133
Fixes brave/brave-browser#11407
Fixes brave/brave-browser#11546
Fixes brave/brave-browser#11547
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.