Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Reverted change that blocked opening of PDF files #6530

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Aug 28, 2020

Resolves brave/brave-browser#11420

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 28, 2020
@samartnik samartnik added this to the 1.15.x - Nightly milestone Aug 28, 2020
@samartnik samartnik self-assigned this Aug 28, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@LaurenWags
Copy link
Member

Reproduced the issue using Samsung Galaxy S8 with Android 9 using both 1.12.113 (Release) and 1.14.70 (Beta). Both versions show a "Can't open file" message as below when trying to open a .pdf from the Downloads page:
android-cantopen

Using Nightly 1.15.23 BraveMonoarm.apk, I did not get a "Can't open file" message, I was able to open a .pdf from the Downloads page after selecting an app:
android-canopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Pdf not opening
5 participants