Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Reverted change that blocked opening of PDF files (uplift to 1.13.x) #6533

Merged
merged 1 commit into from
Sep 1, 2020
Merged

[Android] Reverted change that blocked opening of PDF files (uplift to 1.13.x) #6533

merged 1 commit into from
Sep 1, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Aug 29, 2020 •
edited by kjozwiak
Loading

Uplift of #6530
Resolves brave/brave-browser#11420

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 29, 2020
@samartnik samartnik added this to the Android 1.13.x Release milestone Aug 29, 2020
@samartnik samartnik requested a review from a team August 29, 2020 12:02
kjozwiak
kjozwiak approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6530 (comment).

@kjozwiak kjozwiak merged commit 413c4ea into 1.13.x Sep 1, 2020
@kjozwiak kjozwiak deleted the pr6530_android_open_pdf_1.13.x branch September 1, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.13.x Release #2
Development

Successfully merging this pull request may close these issues.
4 participants
@samartnik @kjozwiak @brave-builds @brave-browser-releases