Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes France and Germany from Gemini supported regions #6538

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 31, 2020

Fixes brave/brave-browser#11483

Submitter Checklist:

Test Plan:

From two fresh profiles, one with install region set to France, and the other Germany, ensure the Gemini widget is not shown on the NTP for either profile.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.15.x - Nightly milestone Aug 31, 2020
@ryanml ryanml requested review from bbondy and emerick August 31, 2020 01:37
@ryanml ryanml self-assigned this Aug 31, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 4532cf1 into master Sep 2, 2020
@ryanml ryanml deleted the fix-11483 branch September 2, 2020 18:04
ryanml added a commit that referenced this pull request Sep 2, 2020
Removes France and Germany from Gemini supported regions
ryanml added a commit that referenced this pull request Sep 2, 2020
@ryanml ryanml modified the milestones: 1.15.x - Nightly, 1.14.x - Beta Sep 2, 2020
@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2020

Verification passed on

Brave 1.15.32 Chromium: 85.0.4183.83 (Official Build) nightly (64-Bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Linux
  • Verified Gemini widget is removed for Germany and France

France

New Tab Add widget New Tab Page settings
Screenshot 2020-09-03 at 2 06 02 p m Screenshot 2020-09-03 at 2 06 08 p m Screenshot 2020-09-03 at 2 06 17 p m

Germany

New Tab Add widget New Tab Page settings
Screenshot 2020-09-03 at 2 09 27 p m Screenshot 2020-09-03 at 2 09 33 p m Screenshot 2020-09-03 at 2 09 43 p m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop][CW] Gemini widget displayed in unsupported region(s)
4 participants