Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes France and Germany from Gemini supported regions (1.13) #6573

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Removes France and Germany from Gemini supported regions (1.13) #6573

merged 1 commit into from
Sep 3, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 2, 2020 •
edited by kjozwiak
Loading

Uplift of #6538
Resolves brave/brave-browser#11483

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml ryanml requested a review from a team September 2, 2020 18:55
@ryanml ryanml self-assigned this Sep 2, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2020

test-unit failed on Android as per https://ci.brave.com/job/pr-brave-browser-gemini-regions-1.13-android/1/execution/node/194/log/. However, this is a known issue that @brave/releng is looking into and doesn't block uplift.

16:21:33  /home/ubuntu/workspace/pr-brave-browser-gemini-regions-1.13-android@tmp/durable-13d8744b/script.sh: 3: /home/ubuntu/workspace/pr-brave-browser-gemini-regions-1.13-android@tmp/durable-13d8744b/script.sh: /home/ubuntu/android-sdk/tools/mksdcard: not found

@kjozwiak kjozwiak added this to the Android 1.13.x Release milestone Sep 3, 2020
kjozwiak
kjozwiak approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6538 (comment).

@kjozwiak kjozwiak merged commit 8d28887 into 1.13.x Sep 3, 2020
@kjozwiak kjozwiak deleted the gemini-regions-1.13 branch September 3, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
feature/crypto-widgets
Projects
None yet
Milestone
1.13.x Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak