Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes login from disconnected state #6555

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 1, 2020

Resolves brave/brave-browser#11528

Submitter Checklist:

Test Plan:

defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.15.x - Nightly milestone Sep 1, 2020
@NejcZdovc NejcZdovc requested a review from a team September 1, 2020 06:26
@NejcZdovc NejcZdovc self-assigned this Sep 1, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team September 1, 2020 06:26
@NejcZdovc NejcZdovc added the CI/skip Do not run CI builds (except noplatform) label Sep 1, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 7cbe4d2 into master Sep 1, 2020
@NejcZdovc NejcZdovc deleted the disconnected-login branch September 1, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove login flow if in Disconnected state
3 participants