Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating fiat currency list for Bitcoin.com [NTP widget] #6790

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Updating fiat currency list for Bitcoin.com [NTP widget] #6790

merged 1 commit into from
Oct 6, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 6, 2020 •
edited
Loading

Fixes brave/brave-browser#12016

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 6, 2020
@ryanml ryanml requested review from emerick and rebron October 6, 2020 18:20
@ryanml ryanml self-assigned this Oct 6, 2020
@ryanml ryanml added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 6, 2020
emerick
emerick approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit e10c405 into master Oct 6, 2020
@ryanml ryanml deleted the fix-12016 branch October 6, 2020 19:05
ryanml added a commit that referenced this pull request Oct 6, 2020
@ryanml
Merge pull request #6790 from brave/fix-12016
78bd2aa 
Updating fiat currency list for Bitcoin.com [NTP widget]
ryanml added a commit that referenced this pull request Oct 6, 2020
@ryanml
Merge pull request #6790 from brave/fix-12016
b3f7e2c 
Updating fiat currency list for Bitcoin.com [NTP widget]
This was referenced Oct 6, 2020
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2020

@ryanml we should probably follow the convention mentioned in the link. Currency type is not capitalized its Australian dollar instead of Australian Dollar

@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2020

Verification passed on

Brave 1.17.18 Chromium: 86.0.4240.72 (Official Build) nightly (x86_64) 1.17.18 Chromium: 86.0.4240.72 (Official Build) nightly (64-bit) 1.17.18 Chromium: 86.0.4240.72 (Official Build) nightly (64-bit)
Revision 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134} 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134} 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS macOS Version 10.15.7 (Build 19H2) Linux Windows 10 OS Version 1809 (Build 17763.1457)
Screenshot image image image
  • Verified the following list of currencies are listed
<div class="FiatItems-sc-321kd3 rTUoB">
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">AUD</div><span class="FiatName-sc-131iu93 DZDvN">Australian dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">BGN</div><span class="FiatName-sc-131iu93 DZDvN">Bulgarian lev</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">CAD</div><span class="FiatName-sc-131iu93 DZDvN">Canadian dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">CHF</div><span class="FiatName-sc-131iu93 DZDvN">Swiss franc</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">CNY</div><span class="FiatName-sc-131iu93 DZDvN">Chinese yuan</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">COP</div><span class="FiatName-sc-131iu93 DZDvN">Colombia peso</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">CZK</div><span class="FiatName-sc-131iu93 DZDvN">Czech Koruna</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">DKK</div><span class="FiatName-sc-131iu93 DZDvN">Danish krone</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">DOP</div><span class="FiatName-sc-131iu93 DZDvN">Dominican peso</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">EGP</div><span class="FiatName-sc-131iu93 DZDvN">Egyptian pound</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">EUR</div><span class="FiatName-sc-131iu93 DZDvN">Euro</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">GBP</div><span class="FiatName-sc-131iu93 DZDvN">Pound sterling</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">HKD</div><span class="FiatName-sc-131iu93 DZDvN">Hong Kong dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">HRK</div><span class="FiatName-sc-131iu93 DZDvN">Croatian kuna</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">IDR</div><span class="FiatName-sc-131iu93 DZDvN">Indonesian rupiah</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">ILS</div><span class="FiatName-sc-131iu93 DZDvN">Israeli new shekel</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">JPY</div><span class="FiatName-sc-131iu93 DZDvN">Japanese yen</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">JOD</div><span class="FiatName-sc-131iu93 DZDvN">Jordanian dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">KES</div><span class="FiatName-sc-131iu93 DZDvN">Kenyan shilling</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">KRW</div><span class="FiatName-sc-131iu93 DZDvN">South Korean won</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">KWD</div><span class="FiatName-sc-131iu93 DZDvN">Kuwaiti dinar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">LKR</div><span class="FiatName-sc-131iu93 DZDvN">Sri Lankan rupee</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">MAD</div><span class="FiatName-sc-131iu93 DZDvN">Moroccan dirham</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">MXN</div><span class="FiatName-sc-131iu93 DZDvN">Mexican peso</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">MYR</div><span class="FiatName-sc-131iu93 DZDvN">Malaysian ringgit</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">NGN</div><span class="FiatName-sc-131iu93 DZDvN">Nigerian naira</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">NOK</div><span class="FiatName-sc-131iu93 DZDvN">Norwegian krone</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">NZD</div><span class="FiatName-sc-131iu93 DZDvN">New Zealand dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">OMR</div><span class="FiatName-sc-131iu93 DZDvN">Omani rial</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">PEN</div><span class="FiatName-sc-131iu93 DZDvN">Peruvian sol</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">PKR</div><span class="FiatName-sc-131iu93 DZDvN">Pakistanee rupee</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">PLN</div><span class="FiatName-sc-131iu93 DZDvN">Polish złoty</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">RON</div><span class="FiatName-sc-131iu93 DZDvN">Romanian leu</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">RUB</div><span class="FiatName-sc-131iu93 DZDvN">Russian ruble</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">SEK</div><span class="FiatName-sc-131iu93 DZDvN">Swedish krona</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">SGD</div><span class="FiatName-sc-131iu93 DZDvN">Singapore dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">THB</div><span class="FiatName-sc-131iu93 DZDvN">Thai baht</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">TRY</div><span class="FiatName-sc-131iu93 DZDvN">Turkish lira</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">TWD</div><span class="FiatName-sc-131iu93 DZDvN">Taiwan dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">USD</div><span class="FiatName-sc-131iu93 DZDvN">United States dollar</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">VND</div><span class="FiatName-sc-131iu93 DZDvN">Vietnamese đồng</span></div>
    <div class="FiatItem-sc-2qhmx4 kdEuAO">
        <div class="FiatSymbol-sc-xnde06 hFhaWa">ZAR</div><span class="FiatName-sc-131iu93 DZDvN">South African rand</span></div>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@rebron rebron Awaiting requested review from rebron

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/crypto-widgets
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging this pull request may close these issues.

[Desktop] updated supported fiat currency for Bitcoin.com widget
3 participants
@ryanml @srirambv @emerick