Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin.com NTP widget fiat updates [1.15] #6791

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 6, 2020

Uplift of #6790, #6783
Fixes: brave/brave-browser#12016, brave/brave-browser#11996

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

ryanml added 2 commits October 6, 2020 12:07
Fixes breaking dropdown arrow for AUD/KRW [Bitcoin.com widget]
Updating fiat currency list for Bitcoin.com [NTP widget]
@ryanml ryanml added this to the 1.15.x - Release #1 milestone Oct 6, 2020
@ryanml ryanml requested a review from a team October 6, 2020 19:10
@ryanml ryanml self-assigned this Oct 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2020

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-bdc-fiat-updates-1.15-macos/2/ using WIPE_WORKSPACE due to init failing as per https://ci.brave.com/job/pr-brave-browser-bdc-fiat-updates-1.15-macos/1/execution/node/104/log/.

15:29:02  Error: Command 'vpython src/third_party/depot_tools/download_from_google_storage.py --no_resume --directory --recursive --no_auth --num_threads=16 --bucket chromium-apache-mac src/third_party/apache-mac' returned non-zero exit status 1 in /Users/jenkins/jenkins/workspace/pr-brave-browser-bdc-fiat-updates-1.15-macos
15:29:02  Hook 'vpython src/third_party/depot_tools/download_from_google_storage.py --no_resume --directory --recursive --no_auth --num_threads=16 --bucket chromium-apache-mac src/third_party/apache-mac' took 24.35 secs

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.15.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6790 (comment).

However, #6783 didn't end up fixing brave/brave-browser#11996 so we'll fix it in a follow up once 1.15.x HF1 is released. Will be addressed via brave/brave-browser#12028.

@kjozwiak kjozwiak merged commit 3ab2d26 into 1.15.x Oct 7, 2020
@kjozwiak kjozwiak deleted the bdc-fiat-updates-1.15 branch October 7, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants