Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes breaking dropdown arrow for AUD/KRW [Bitcoin.com widget] #6783

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 6, 2020

Fixes brave/brave-browser#11996

Left margin was excessive

Screen Shot 2020-10-05 at 11 33 58 PM

Screen Shot 2020-10-05 at 11 33 52 PM

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 6, 2020
@ryanml ryanml requested review from AlanBreck and emerick October 6, 2020 07:04
@ryanml ryanml self-assigned this Oct 6, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 6429ee9 into master Oct 6, 2020
@ryanml ryanml deleted the fix-11996 branch October 6, 2020 11:13
ryanml added a commit that referenced this pull request Oct 6, 2020
Fixes breaking dropdown arrow for AUD/KRW [Bitcoin.com widget]
ryanml added a commit that referenced this pull request Oct 6, 2020
Fixes breaking dropdown arrow for AUD/KRW [Bitcoin.com widget]
@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2020

Margin can be upto 2.5px so that other tokens KRW/KWD/TWD don't break
image

KWD breaks at 3px as well so having 2.5px fixes it for all
image

But having margin set to 2.5px causes other currencies like IDL/ILS/JPY/JOD to look odd
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown arrow is moved to next line for certain currencies
3 participants