Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown arrow is moved to next line for certain currencies #11996

Closed
srirambv opened this issue Oct 5, 2020 · 1 comment · Fixed by brave/brave-core#6783
Closed

Dropdown arrow is moved to next line for certain currencies #11996

srirambv opened this issue Oct 5, 2020 · 1 comment · Fixed by brave/brave-core#6783
Assignees
@ryanml
Labels
feature/widgets OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA/No release-notes/exclude
Milestone
1.15.x - Release #1

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2020

Description

Dropdown arrow is moved to next line for certain currencies

Steps to Reproduce

  1. Install 1.15.70
  2. Open Bitcoin.com widget
  3. Select AUD / KRW from dropdown list

Actual result:

image

Expected result:

Should not push dropdown indicator to the next line

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.15.70 Chromium: 86.0.4240.68 (Official Build) (64 Bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:
@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/widgets OS/Desktop labels Oct 5, 2020
ryanml added a commit to brave/brave-core that referenced this issue Oct 6, 2020
@ryanml
Fixes brave/brave-browser#11996 - Fixes breaking dropdown arrow for A…
ce8f92f 
…UD/KRW
@ryanml ryanml self-assigned this Oct 6, 2020
@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 6, 2020
@ryanml ryanml mentioned this issue Oct 6, 2020
Merged
33 tasks
@ryanml ryanml mentioned this issue Oct 6, 2020
Merged
4 tasks
@ryanml ryanml mentioned this issue Oct 6, 2020
Merged
4 tasks
@srirambv srirambv mentioned this issue Oct 7, 2020
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Oct 7, 2020

This is superseded by #12028 which is fixed for all currencies. Marking as QA/No as still a few currencies show dropdown arrow on next line

@srirambv srirambv added QA/No and removed QA/Yes labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/widgets OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA/No release-notes/exclude
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes breaking dropdown arrow for AUD/KRW [Bitcoin.com widget] brave/brave-core
2 participants
@ryanml @srirambv