Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send stats usage ping when channel=developer #6834

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Oct 12, 2020

The only exception to this case is when a custom stats updater server is
passed on the command line so devs can test the updater.

Resolves brave/brave-browser#12096

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@kkuehlz kkuehlz requested a review from zenparsing October 12, 2020 18:33
@kkuehlz kkuehlz force-pushed the stats_url_dcheck_more_lenient branch from 8aa4cca to 3af2b9d Compare October 12, 2020 18:34
@kkuehlz kkuehlz added this to the 1.17.x - Nightly milestone Oct 12, 2020
@kkuehlz kkuehlz added the CI/skip Do not run CI builds (except noplatform) label Oct 12, 2020
@kkuehlz kkuehlz force-pushed the stats_url_dcheck_more_lenient branch from 3af2b9d to 24841c8 Compare October 12, 2020 18:50
@kkuehlz kkuehlz requested a review from bridiver October 12, 2020 18:50
@kkuehlz kkuehlz force-pushed the stats_url_dcheck_more_lenient branch from 24841c8 to c085d14 Compare October 12, 2020 18:54
@kkuehlz kkuehlz force-pushed the stats_url_dcheck_more_lenient branch from c085d14 to 8e6a7bd Compare October 13, 2020 22:01
@kkuehlz kkuehlz removed the CI/skip Do not run CI builds (except noplatform) label Oct 13, 2020
@kkuehlz kkuehlz requested a review from bsclifton October 13, 2020 22:04
@kkuehlz kkuehlz force-pushed the stats_url_dcheck_more_lenient branch from 8e6a7bd to c8bd8bf Compare October 13, 2020 22:05
@kkuehlz kkuehlz changed the title Dev builds won't have the stats_updater_url Don't send stats usage ping when channel=developer Oct 13, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@kkuehlz kkuehlz force-pushed the stats_url_dcheck_more_lenient branch 3 times, most recently from f479b9f to aeefc5d Compare October 16, 2020 03:06
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ++

@kkuehlz kkuehlz added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 16, 2020
@kkuehlz kkuehlz merged commit 6dbf916 into master Oct 16, 2020
@kkuehlz kkuehlz deleted the stats_url_dcheck_more_lenient branch October 16, 2020 20:07
@bsclifton bsclifton mentioned this pull request Jan 31, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats_updater_url not set in dev builds
3 participants