Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer term stats URL crash fix #7754

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Longer term stats URL crash fix #7754

merged 2 commits into from
Feb 1, 2021

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 31, 2021

Proper fix for brave/brave-browser#13858

Change behavior introduced with #6834

While talking it out with @bridiver, we changed the behavior from just a DCHECK to a CHECK with the intent that we don't want to be releasing builds which don't have stats URL set. This PR updates the behavior to just log an error instead (which QA can look for during testing / release)

Longer term fix was agreed to be catching this in the pipeline. We need to make sure the pipeline has this set and if it's not set, we should fail the job

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This reverts commit 50e0c14, reversing
changes made to 1aa51cb.
We can update our QA test plan to make sure this message doesn't show up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants