Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes verified message on tipping banner (uplift to 1.17.x) #6992

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 30, 2020

Uplift of #6983
Resolves brave/brave-browser#12362

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 30, 2020 06:59
@brave-builds brave-builds requested review from zenparsing, NejcZdovc and a team and removed request for a team October 30, 2020 06:59
@brave-builds brave-builds self-assigned this Oct 30, 2020
@brave-builds brave-builds added this to the 1.17.x - Beta milestone Oct 30, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Nov 2, 2020

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-pr6983_connected-publisher_1.17.x-macos/2/ using WIPE_WORKSPACE due to init failing as per https://ci.brave.com/job/pr-brave-browser-pr6983_connected-publisher_1.17.x-macos/1/execution/node/111/log/.

02:11:07  Error: Command 'vpython src/third_party/depot_tools/download_from_google_storage.py --no_resume --directory --recursive --no_auth --num_threads=16 --bucket chromium-apache-mac src/third_party/apache-mac' returned non-zero exit status 252 in /Users/jenkins/jenkins/workspace/pr-brave-browser-pr6983_connected-publisher_1.17.x-macos
02:11:07  Hook 'vpython src/third_party/depot_tools/download_from_google_storage.py --no_resume --directory --recursive --no_auth --num_threads=16 --bucket chromium-apache-mac src/third_party/apache-mac' took 27.57 secs

@kjozwiak
Copy link
Member

kjozwiak commented Nov 3, 2020

audit-deps failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr6983_connected-publisher_1.17.x-macos/2/execution/node/144/log/. However, this is a known issue which was addressed with #7003. Doesn't block uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.17.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6983 (comment).

@kjozwiak kjozwiak merged commit 2076716 into 1.17.x Nov 3, 2020
@kjozwiak kjozwiak deleted the pr6983_connected-publisher_1.17.x branch November 3, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants