Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12436: Fix audit-deps failure in speedreader #7003

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 31, 2020

Resolves brave/brave-browser#12436

Submitter Checklist:

Test Plan:

npm run audit_deps should pass

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde requested a review from iefremov as a code owner October 31, 2020 05:29
@jumde jumde self-assigned this Oct 31, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jumde
Copy link
Contributor Author

jumde commented Nov 2, 2020

Known test failures (on windows):

brave/brave-browser#12295
brave/brave-browser#12388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit-deps failing for futures-util
3 participants