Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12436: Fix audit-deps failure in speedreader (uplift to 1.17.x) #7005

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 2, 2020

Uplift of #7003
Resolves brave/brave-browser#12436

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team November 2, 2020 05:29
@brave-builds brave-builds self-assigned this Nov 2, 2020
@brave-builds brave-builds added this to the 1.17.x - Beta milestone Nov 2, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Nov 2, 2020

Restarting iOS via https://ci.brave.com/job/pr-brave-browser-pr7003_npm_audit_1.17.x-ios/2/ due to init failing as per https://ci.brave.com/job/pr-brave-browser-pr7003_npm_audit_1.17.x-ios/1/execution/node/106/log/.

00:42:01  Hook 'vpython src/build/download_nacl_toolchains.py --mode nacl_core_sdk sync --extract' took 39.29 secs
00:42:01  ________ running 'vpython src/build/mac_toolchain.py --xcode-version default' in '/Users/jenkins/jenkins/workspace/pr-brave-browser-pr7003_npm_audit_1.17.x-ios'

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.17.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit a0c8452 into 1.17.x Nov 2, 2020
@kjozwiak kjozwiak deleted the pr7003_npm_audit_1.17.x branch November 2, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants