Improve rewards onboarding experience

[zenparsing]

This PR introduces the following changes:

• Show rewards onboarding UX in various entry points independently.
• Do not show rewards onboarding to existing opted-in rewards users.

Resolves brave/brave-browser#12675
Resolves brave/brave-browser#12612

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint, npm run gn_check)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Requested a security/privacy review as needed.
• Added appropriate QA labels (QA/Yes or QA/No) to the associated issue
• Added appropriate release note labels (release-notes/include or release-notes/exclude) to the associated issue
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Showing onboarding at different entry points independently

Note: the following steps should demonstrate the same behavior, regardless of the order of the entry points visited (the rewards page, the rewards panel, or the tip dialog).

• Start the browser with a clean profile.
• Open the rewards panel.
  • Verify that an onboarding modal is displayed.
• Click the "X" to close the modal.
• Close the rewards panel.
• Navigate to a publisher URL (e.g. https://laurenwags.github.io)
• Open the rewards panel.
  • Verify that on onboarding modal is not displayed.
• Click "Send a tip".
  • Verify that an onboarding screen is displayed in the tip dialog.
• Click the "X" to close the tip dialog. Click the "Maybe Later" link to dismiss onboarding.
• Open the rewards panel and click "Send a tip".
  • Verify that an onboarding screen is not displayed in the tip dialog.
• Navigate to the rewards page.
  • Verify that an onboarding modal is displayed.
• Click the "X" to close the modal.
• Reload the page.
  • Verify that an onboarding modal is not displayed.

Onboarding is not displayed for upgraded users with Rewards enabled

• Start a 1.17 browser with a clean profile.
• Navigate to the rewards page.
• Enable rewards and turn Ads off.
• Close the browser.
• With the same profile, start the browser (with this change).
• Navigate to the rewards page.
  • Verify that the oboarding modal is not displayed.
• Open the rewards panel.
  • Verify that the onboarding modal is not displayed.
• Navigate to a publisher page.
• Open the rewards panel and click "Send a tip".
  • Verify that the onboarding screen is not displayed.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[emerick]

LGTM

[marshall]

looks good! I left a question for curiosity sake, but no changes requested.

[LaurenWags]

Verified passed with

Brave	1.19.30 Chromium: 87.0.4280.67 (Official Build) nightly (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from #7135 (comment)

Verified steps from Showing onboarding at different entry points independently

• Confirmed steps as written (in that specific order) worked as expected
• Confirmed restarting the browser and visiting brave://rewards, panel, or tipping banner did not show the onboarding after it had been dismissed
• Viewed the brave://rewards, banner, and panel in sequences other than outlined in the steps (ex. Open in-line tip banner via Twitter, dismiss onboarding. Open brave://rewards page, dismiss onboarding. Visit a site, open panel, dismiss onboarding, etc). Confirmed the onboarding in various order/entry points.

Screenshots

Panel onboarding:

Panel after dismissing onboarding:

Banner onboarding:

Banner after dismissing onboarding:

brave://rewards onboarding:

brave://rewards after dismissing onboarding:

Upgrade Case 1 - Rewards never enabled on 1.17.x

• Confirmed after upgrading to 1.19.x, I was shown the onboarding on brave://rewards, panel, and banner until it was dismissed.

Upgrade Case 2 - Rewards enabled (AC + Ads enabled) on 1.17.x

• Confirmed after upgrading to 1.19.x, I was not shown the onboarding on brave://rewards, panel, or banner

Upgrade Case 3 - Rewards enabled, then disabled on 1.17.x

• Confirmed after upgrading to 1.19.x, I was shown the onboarding on brave://rewards, panel, and banner until it was dismissed.

Upgrade Case 4 - Rewards enabled (Ads on, AC off) on 1.17.x

• Confirmed after upgrading to 1.19.x, I was not shown the onboarding on brave://rewards, panel, or banner

Upgrade Case 5 - Rewards enabled (Ads off, AC on) on 1.17.x (Onboarding is not displayed for upgraded users with Rewards enabled)

• Confirmed after upgrading to 1.19.x, I was not shown the onboarding on brave://rewards, panel, or banner

Upgrade Case 6 - Rewards enabled (AC + Ads off) on 1.17.x

• Confirmed after upgrading to 1.19.x, I was not shown the onboarding on brave://rewards, panel, or banner