Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rewards onboarding experience (uplift to 1.18.x) #7155

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 16, 2020

Uplift of #7135
Resolves brave/brave-browser#12675
Resolves brave/brave-browser#12612

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 16, 2020 16:51
@brave-builds brave-builds requested review from marshall, emerick and a team and removed request for a team November 16, 2020 16:51
@brave-builds brave-builds self-assigned this Nov 16, 2020
@brave-builds brave-builds added this to the 1.18.x - Beta milestone Nov 16, 2020
@kjozwiak
Copy link
Member

@kjozwiak
Copy link
Member

test-browser failed on Win x64 due to https://ci.brave.com/job/pr-brave-browser-pr7135_ksmith-rewards-onboarding-fixes_1.18.x-windows/7/execution/node/246/log/. However, the reward timeout is an intermittent issue and doesn't block uplift.

12:20:00  1 test timed out:
12:20:00      RewardsBrowserTest.BackupRestoreModalHasNotice (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:303)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7135 (comment).

@kjozwiak kjozwiak merged commit e937d7a into 1.18.x Nov 24, 2020
@mihaiplesa mihaiplesa deleted the pr7135_ksmith-rewards-onboarding-fixes_1.18.x branch November 25, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants