Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11895: Fix buffer overrun in GetCryptoRandomString(). #7262

Merged
merged 2 commits into from
Dec 1, 2020
Merged

11895: Fix buffer overrun in GetCryptoRandomString(). #7262

merged 2 commits into from
Dec 1, 2020

Commits on Dec 1, 2020

  1. 11895: Fix buffer overrun in GetCryptoRandomString(). 

    Fixes brave/brave-browser#11895

Passing char* to Base64Encode was triggering an implicit
construction of StringPiece from a "string" which wasn't
null terminated. Using Base64Encode version that takes
a base::span will make us safe.
    @iefremov
    iefremov committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    02e2235 View commit details
    Browse the repository at this point in the history

  2. 11895: Fix another memory bug and enable asan for problematic tests.

    @iefremov
    iefremov committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    26f349b View commit details
    Browse the repository at this point in the history