Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement promoted content ads #7572

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Implement promoted content ads #7572

merged 1 commit into from
Jan 15, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 12, 2021

Resolves brave/brave-browser#13468

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Confirm users are rewarded BAT for viewing promoted content within Brave Today. The catalog contains a new ad type promoted_content_all_v1 where the creative_instance_id has to match the Brave Today feed
  • Confirm viewed confirmations (up to 4 per hour and 20 per day) are redeemed with the server (see diagnostic log and confirm with server team)
  • Confirm clicked confirmations are redeemed with the server (see diagnostic log and confirm with server team)

@tmancey tmancey requested a review from moritzhaller January 12, 2021 17:35
@tmancey tmancey self-assigned this Jan 12, 2021
@tmancey tmancey changed the title Implement Brave Today ads Implement promoted content ads Jan 13, 2021
@tmancey tmancey force-pushed the issues/13468 branch 16 times, most recently from 1e30779 to 63897e5 Compare January 13, 2021 15:04
@tmancey tmancey marked this pull request as ready for review January 13, 2021 15:04
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS changes look good

@tmancey tmancey removed the request for review from iefremov January 14, 2021 11:45
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT++

@tmancey tmancey merged commit cd7eb13 into master Jan 15, 2021
@tmancey tmancey deleted the issues/13468 branch January 15, 2021 16:45
@tmancey tmancey added this to the 1.21.x - Nightly milestone Jan 15, 2021
petemill pushed a commit that referenced this pull request Feb 1, 2021
Implement promoted content ads
@stephendonner
Copy link
Contributor

@tmancey 👋 ; thanks for the test plan! Would you mind fleshing it out a bit, with command-line args with dev/staging environments, suitable for testing this? Should we be using --brave-ads-staging and --rewards=staging=true, or --brave-ads-development and --rewards=development=true, in tandem?

Over in brave/brave-browser#13695 I have been able to get the dev Brave Today feed up (launching with --brave-today-host=brave-today-cdn.brave.software), but have errors, and don't see the appropriate view and click ad events I'd associate with it.

Anything else to omit or ad to the below, either? Thanks!

--args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-debug --brave-today-host=brave-today-cdn.brave.software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement promoted content ads
4 participants