-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement promoted content ads #7572
Conversation
1e30779
to
63897e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT++
Implement promoted content ads
@tmancey 👋 ; thanks for the test plan! Would you mind fleshing it out a bit, with command-line args with dev/staging environments, suitable for testing this? Should we be using Over in brave/brave-browser#13695 I have been able to get the dev Brave Today feed up (launching with Anything else to omit or ad to the below, either? Thanks!
|
Resolves brave/brave-browser#13468
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
promoted_content_all_v1
where thecreative_instance_id
has to match the Brave Today feed