Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave Today: Promoted content #13695

Closed
petemill opened this issue Jan 21, 2021 · 3 comments · Fixed by brave/brave-core#7290
Closed

[Desktop] Brave Today: Promoted content #13695

petemill opened this issue Jan 21, 2021 · 3 comments · Fixed by brave/brave-core#7290

Comments

@petemill
Copy link
Member

Description

Consume promoted content from the Brave Today feed, display with a "Promoted" label, and register views and clicks via the internal ads library.

Steps to Reproduce

  1. Consume dev feed for Brave Today
  2. Observe there is 1 promoted content item per "page" of Brave Today content. It should be labelled as "Promoted"
  3. Observe that the promoted item image fits and is not cropped like all the other Brave Today content images.
@LaurenWags
Copy link
Member

Per discussion with @jsecretan , testing of this will be basic checks. I have also marked as release-notes/exclude for now. cc @rebron @kjozwiak

@btlechowski
Copy link

btlechowski commented Mar 1, 2021

Verification passed on

Brave 1.21.70 Chromium: 89.0.4389.69 (Official Build) (64-bit)
Revision 6df9174a477a0bea2118cb4669954d517be16104-refs/branch-heads/4389@{#1332}
OS Ubuntu 18.04 LTS

Verified test plan from #13695 and brave/brave-core#7572

Verified on dev feed and staging ads servers on US region

Verified Promoted content is shown in the feed:
image

Verified when Promoted content is in view then user is rewarded for it:

[30794:30794:0301/212023.111421:VERBOSE3:promoted_content_ad_event_viewed.cc(24)] Viewed promoted content ad with uuid f8e31285632512d455e928d10c6bfc2836df0319397bdadbb386ddee03734311 and creative instance id f7209795-2a75-48a1-8e23-816dc6238f42
[30794:30794:0301/212023.111575:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id f7209795-2a75-48a1-8e23-816dc6238f42
[30794:30794:0301/212023.120250:VERBOSE6:promoted_content_ad_event_viewed.cc(33)] Successfully logged promoted content ad viewed event

[30794:30794:0301/212023.786607:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 6fb2ecfd-b0b3-4ffb-848f-20ad0b9b94b3, creative instance id f7209795-2a75-48a1-8e23-816dc6238f42 and view
[30794:30794:0301/212023.786875:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

image

Verified the ad is listed in 7 day history
image

Verified clicked event:

[30794:30794:0301/212508.483337:VERBOSE3:promoted_content_ad_event_clicked.cc(24)] Clicked promoted content ad with uuid f8e31285632512d455e928d10c6bfc2836df0319397bdadbb386ddee03734311 and creative instance id f7209795-2a75-48a1-8e23-816dc6238f42
[30794:30794:0301/212508.483658:VERBOSE1:confirmations.cc(90)] Confirming click ad for creative instance id f7209795-2a75-48a1-8e23-816dc6238f42

[30794:30794:0301/212509.075644:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id e7b8b28a-b272-4c26-be33-492b28fb8bd5, creative instance id f7209795-2a75-48a1-8e23-816dc6238f42 and click
[30794:30794:0301/212509.076263:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 4 unblinded payment tokens

Verified landed event:

[30794:30794:0301/212523.122072:VERBOSE1:ad_transfer.cc(140)] Transferred ad for https://www.etoro.com/news-and-analysis/crypto/crypto-roundup-march-1-2021-cardano-bucks-the-trend-as-crypto-market-pulls-back/
[30794:30794:0301/212523.122189:VERBOSE1:confirmations.cc(90)] Confirming landed ad for creative instance id f7209795-2a75-48a1-8e23-816dc6238f42

[30794:30794:0301/212523.683823:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id bf985a9f-1305-4c61-a46e-6c0790f279f5, creative instance id f7209795-2a75-48a1-8e23-816dc6238f42 and landed
[30794:30794:0301/212523.684609:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 5 unblinded payment tokens

Verified there is 1 promoted content item per "page" of Brave Today content
image

Logged Promoted content ads view event is not triggered for small window sizes #14420
Logged Add ability to easily turn off/on promoted content ads #14422

Verified user can view a notification ad and be rewarded for it:
image

[32236:32236:0301/224638.913690:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: 822740a9-dddb-48da-b5bb-101229011766
  creativeInstanceId: ed6c467a-8643-42eb-a7cd-32e878fa3cd4
  creativeSetId: a9f0b49c-3298-4c1b-a8b5-76a71e8d7332
  campaignId: 0e70c893-b0c0-4dab-860d-7e65446f0f0f
  segment: untargeted
  title: This is a test
  body: This is a test
  targetUrl: https://www.brave.com
[32236:32236:0301/224638.914484:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 822740a9-dddb-48da-b5bb-101229011766 and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[32236:32236:0301/224638.914780:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4


[32236:32236:0301/224639.521781:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id b5194c2b-a178-4a73-8d9f-f9280ee286b0, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and view
[32236:32236:0301/224639.522118:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 2 unblinded payment tokens

Verified user can view a NTP SI ad and be rewarded for it:
image

[3887:3887:0301/232716.826874:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 9c61af71-7a39-474a-b5c8-0e5a7d4edf94 and creative instance id 27c508bf-1076-4fcd-9b9a-ac394978cc56
[3887:3887:0301/232716.827669:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 27c508bf-1076-4fcd-9b9a-ac394978cc56


Verification passed on

Brave | 1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified test plan from #13695 and brave/brave-core#7572

  • Verified brave today feeds in staging ads server for US region

  • Verified Promoted content is shown in the feed
    image

  • Verified when Promoted content is in view then user is rewarded for it:

[15948:2980:0303/152737.846:VERBOSE3:promoted_content_ad_event_viewed.cc(24)] Viewed promoted content ad with uuid c3f8692fb3284b4a8a41a72e8c764d3c2debf9fc57a0c611e08cb5bdf0628dad and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[15948:2980:0303/152737.846:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[15948:2980:0303/152737.896:VERBOSE6:promoted_content_ad_event_viewed.cc(33)] Successfully logged promoted content ad viewed event


[15948:2980:0303/152738.825:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 76ff705a-b6db-4371-9d4d-25b8b4ed869e, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and view
[15948:2980:0303/152738.833:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

image

Verified the ad is listed in 7 day history
image

Verified clicked event:

[12184:20508:0303/162304.580:VERBOSE3:promoted_content_ad_event_clicked.cc(24)] Clicked promoted content ad with uuid c3f8692fb3284b4a8a41a72e8c764d3c2debf9fc57a0c611e08cb5bdf0628dad and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[12184:20508:0303/162304.581:VERBOSE1:confirmations.cc(90)] Confirming click ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[12184:20508:0303/162426.028:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 0df6c01c-a84d-4dd9-84e4-7f5e928d02ba, creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9 and click
[12184:20508:0303/162426.028:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 5 unblinded payment tokens

Verified landed event:

[12184:20508:0303/162323.007:VERBOSE1:ad_transfer.cc(140)] Transferred ad for https://newsletter.banklesshq.com/p/how-to-make-bank-off-the-funding
[12184:20508:0303/162323.008:VERBOSE1:confirmations.cc(90)] Confirming landed ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[12184:20508:0303/162324.049:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 7c4273c2-5bbe-44e2-bac8-f837a04ddc35, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and landed
[12184:20508:0303/162324.056:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 3 unblinded payment tokens

Verified there is 1 promoted content item per "page" of Brave Today content
image

  • Verified that users can view ads and rewarded for it
    image
    image
[12184:20508:0303/162409.847:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: 63493fd7-6b9f-4d66-b2bf-9e502136bae7
  creativeInstanceId: 4983dc92-09fd-4e5c-94c3-616a4728c1d9
  creativeSetId: 5bdeab83-048f-48a7-9602-a1092ded123c
  campaignId: 63010037-c230-40db-b41a-3127619b88e4
  segment: untargeted
  title: This is a test
  body: This is a test
  targetUrl: https://www.brave.com
[12184:20508:0303/162409.848:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 63493fd7-6b9f-4d66-b2bf-9e502136bae7 and creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9
[12184:20508:0303/162409.849:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9

Verified user can view a NTP SI ad and be rewarded for it:

image
image
image

[15496:17044:0303/165121.605:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 8f0efbee-d360-47ed-bd1b-2b5513b73177 and creative instance id a24d107b-2dc9-40cc-8b8f-4ff4f706d783
[15496:17044:0303/165121.605:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id a24d107b-2dc9-40cc-8b8f-4ff4f706d783
[15496:17044:0303/165121.608:VERBOSE1:redeem_unblinded_token.cc(49)] Redeem unblinded token
[15496:17044:0303/165121.615:VERBOSE1:redeem_unblinded_token.cc(63)] CreateConfirmation
[15496:17044:0303/165121.615:VERBOSE2:redeem_unblinded_token.cc(64)] POST /v1/confirmation/{confirmation_id}/{credential}
[15496:17044:0303/165121.617:VERBOSE5:redeem_unblinded_token.cc(68)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/9abf7c5e-3a18-404e-a386-a89410a89671/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwidEVDcGdaRXVBK3RvVU1UZXlGWEVLN1owQWc4cktWaHFsWEo3RWZNeHQxND1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIklOXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImEyNGQxMDdiLTJkYzktNDBjYy04YjhmLTRmZjRmNzA2ZDc4M1wiLFwiZXhwZXJpbWVudFwiOnt9LFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIndpbmRvd3NcIixcInR5cGVcIjpcInZpZXdcIn0iLCJzaWduYXR1cmUiOiIyT3BSNDVuYkhSZFFydFpQaGN4L0tsNU9tN3dqa0tObWVYL1FLdHpOaXJKdmsxNzJscDk1M1pzOGFOWHpBdm1adTNIR3BoM2oyckgxWlJ1SnhjQW9kQT09IiwidCI6InphcFhBbXhyaXlVVmpQUXR5ek5UZXY5cEFibFJxa0NCRFFIdlN1OWpFVzNOYkh0Z0JVQUl3ekJVRnU4S2s2REt1WURxWG8xRitmQ1kwL0xXa2hGdTZ3PT0ifQ==
  Content: {"blindedPaymentToken":"tECpgZEuA+toUMTeyFXEK7Z0Ag8rKVhqlXJ7EfMxt14=","buildChannel":"release","countryCode":"IN","creativeInstanceId":"a24d107b-2dc9-40cc-8b8f-4ff4f706d783","experiment":{},"payload":{},"platform":"windows","type":"view"}
  Content Type: application/json
  Method: BraveAdsUrlRequestMethod::POST
[15496:17044:0303/165121.623:VERBOSE6:new_tab_page_ad_event_viewed.cc(33)] Successfully logged new tab page ad viewed event

@stephendonner
Copy link

stephendonner commented Mar 2, 2021

Verification PASSED; launched with --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --brave-today-host=brave-today-cdn.brave.software --rewards=staging=true,reconcile-interval=5 using

Brave 1.21.70 Chromium: 89.0.4389.69 (Official Build) (x86_64)
Revision 6df9174a477a0bea2118cb4669954d517be16104-refs/branch-heads/4389@{#1332}
OS macOS Version 11.2.2 (Build 20D80)

Verified test plan from #13695 and brave/brave-core#7572

Verified on dev feed and staging ads servers on US region

Verified Promoted content is shown in the feed:
Screen Shot 2021-03-01 at 5 20 38 PM

Verified when Promoted content is fully in view then user is rewarded for it:

[2895:775:0301/171543.799165:VERBOSE3:promoted_content_ad_event_viewed.cc(24)] Viewed promoted content ad with uuid 5ba75daab97c741993961fa0a281e45811dea80699e51a6935f8e28e90af749a and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[2895:775:0301/171543.799453:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[2895:775:0301/171543.800092:VERBOSE1:redeem_unblinded_token.cc(49)] Redeem unblinded token
[2895:775:0301/171543.802108:VERBOSE6:promoted_content_ad_event_viewed.cc(33)] Successfully logged promoted content ad viewed event
[2895:775:0301/171544.139359:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id cc19806a-3f94-4976-b843-d8dbfba1738e, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and view
[2895:775:0301/171544.139784:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Screen Shot 2021-03-01 at 5 25 27 PM

Verified the ad is listed in 7 day Ads History
Screen Shot 2021-03-01 at 5 25 17 PM

Verified clicked event:

[2895:775:0301/171552.865848:VERBOSE3:promoted_content_ad_event_clicked.cc(24)] Clicked promoted content ad with uuid 5ba75daab97c741993961fa0a281e45811dea80699e51a6935f8e28e90af749a and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[2895:775:0301/171552.866065:VERBOSE1:confirmations.cc(90)] Confirming click ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[2895:775:0301/171552.873557:VERBOSE6:promoted_content_ad_event_clicked.cc(33)] Successfully logged promoted content ad clicked event
[2895:775:0301/171553.036911:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 0addc02b-6a14-4132-92c8-22ea7f330707, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and click
[2895:775:0301/171553.037791:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 2 unblinded payment tokens

Confirmed landed ad event:

[2895:775:0301/171603.795061:VERBOSE1:ad_transfer.cc(140)] Transferred ad for https://newsletter.banklesshq.com/p/nfts-are-mainstream-market-monday
[2895:775:0301/171603.795342:VERBOSE1:confirmations.cc(90)] Confirming landed ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[2895:775:0301/171603.796403:VERBOSE1:redeem_unblinded_token.cc(49)] Redeem unblinded token
[2895:775:0301/171603.803468:VERBOSE6:ad_transfer.cc(149)] Successfully logged transferred ad event
[2895:775:0301/171603.977360:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id 697c803e-458d-48aa-b0dc-a5db367e4f9b, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and landed
[2895:775:0301/171603.978069:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 3 unblinded payment tokens

Verified there is 1 promoted content item per "page" of Brave Today content (see first image)

Verified user can view a notification ad and be rewarded for it:
image

[711:775:0301/144404.752855:VERBOSE1:ad_notification_serving.cc(101)] Ad notification delivered:
  uuid: 77a1a548-0236-4ded-8a05-6cc16bd644ee
  creativeInstanceId: ed6c467a-8643-42eb-a7cd-32e878fa3cd4
  creativeSetId: a9f0b49c-3298-4c1b-a8b5-76a71e8d7332
  campaignId: 0e70c893-b0c0-4dab-860d-7e65446f0f0f
  segment: untargeted
  title: This is a test
  body: This is a test
  targetUrl: https://www.brave.com
[711:775:0301/144404.752901:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 77a1a548-0236-4ded-8a05-6cc16bd644ee and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[711:775:0301/144404.753221:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[711:775:0301/144404.789043:VERBOSE6:ad_notification_event_viewed.cc(33)] Successfully logged ad notification viewed event
[711:775:0301/144405.131206:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id e0da91c4-c1f0-42ba-bc1a-93a4282098f7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and view
[711:775:0301/144405.131919:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Verified user can view a NTP SI ad and be rewarded for it:
Screen Shot 2021-03-02 at 8 53 43 AM

[5048:775:0302/085224.446189:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid baebc8a2-6896-49b2-b5b8-c07a0be6c508 and creative instance id 500f0553-b488-4ad9-aead-ff1e8ea87543
[5048:775:0302/085224.446346:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 500f0553-b488-4ad9-aead-ff1e8ea87543
[5048:775:0302/085224.447322:VERBOSE1:redeem_unblinded_token.cc(49)] Redeem unblinded token
[5048:775:0302/085224.607587:VERBOSE1:confirmations.cc(224)] Successfully redeemed unblinded token with confirmation id b4d5fded-2811-4a8d-9805-7ff1482181e8, creative instance id 500f0553-b488-4ad9-aead-ff1e8ea87543 and view
[5048:775:0302/085224.608144:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants