Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today: promoted content #7290

Merged
merged 5 commits into from
Jan 22, 2021
Merged

Brave Today: promoted content #7290

merged 5 commits into from
Jan 22, 2021

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 1, 2020

Resolves brave/brave-browser#13695

Follow-ups

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Manually verify with steps in Issue

@petemill petemill self-assigned this Dec 1, 2020
@petemill petemill requested review from bsclifton and ryanml December 1, 2020 08:20
@petemill petemill force-pushed the today-promoted branch 2 times, most recently from 8a3192d to 5dc8f42 Compare December 1, 2020 08:57
@petemill petemill force-pushed the today-promoted branch 2 times, most recently from f9ed68c to 980af21 Compare January 14, 2021 07:06
@@ -609,6 +627,20 @@ void BraveNewTabMessageHandler::HandleTodayOnCardViews(
base::size(kBuckets) + 1);
}

void BraveNewTabMessageHandler::HandleTodayOnPromotedCardView(
const base::ListValue* args) {
// Argument should be how many cards viewed in this session.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: check we have enough args

@petemill
Copy link
Member Author

petemill commented Jan 14, 2021

Apart from @tmancey, please don't review this yet. Needs to be rebased once the base branch is merged, and then some automatic reviewers can be removed!

@petemill
Copy link
Member Author

This is ready for review. Thanks!

@petemill petemill requested review from tmancey and removed request for kylehickinson and iefremov January 21, 2021 06:22
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Brave Today: Promoted content
2 participants