-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave Today: promoted content #7290
Conversation
components/brave_new_tab_ui/components/default/braveToday/cards/_articles/cardArticleLarge.tsx
Outdated
Show resolved
Hide resolved
4d805f5
to
a76109b
Compare
8a3192d
to
5dc8f42
Compare
5dc8f42
to
86ee87c
Compare
f9ed68c
to
980af21
Compare
@@ -609,6 +627,20 @@ void BraveNewTabMessageHandler::HandleTodayOnCardViews( | |||
base::size(kBuckets) + 1); | |||
} | |||
|
|||
void BraveNewTabMessageHandler::HandleTodayOnPromotedCardView( | |||
const base::ListValue* args) { | |||
// Argument should be how many cards viewed in this session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: check we have enough args
components/brave_new_tab_ui/components/default/braveToday/cards/_articles/cardArticleLarge.tsx
Outdated
Show resolved
Hide resolved
Apart from @tmancey, please don't review this yet. Needs to be rebased once the base branch is merged, and then some automatic reviewers can be removed! |
980af21
to
834e48c
Compare
… from Flag is `--brave-today-host` and allows to use, for example, staging, dev or a local in-development feed.
834e48c
to
c8827e9
Compare
This is ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Resolves brave/brave-browser#13695
--brave-today-host
and allows to use, for example, staging, dev or a local in-development feed.Follow-ups
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: