Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook build error #7696

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Fix storybook build error #7696

merged 1 commit into from
Jan 26, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#13753

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run storybook completes successfully.

@zenparsing zenparsing requested a review from petemill January 25, 2021 21:09
@zenparsing zenparsing self-assigned this Jan 25, 2021
@darkdh darkdh mentioned this pull request Jan 25, 2021
23 tasks
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much!

@petemill petemill merged commit bcbb650 into master Jan 26, 2021
@petemill petemill deleted the ksmith-fix-storybook branch January 26, 2021 23:28
@petemill petemill mentioned this pull request Jan 26, 2021
23 tasks
@zenparsing zenparsing added this to the 1.21.x - Nightly milestone Jan 27, 2021
petemill added a commit that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook is failing to build due to a TypeScript error
3 participants