Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hard coded text for welcome panel #766

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Adds hard coded text for welcome panel #766

merged 1 commit into from
Oct 30, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 30, 2018

Resolves brave/brave-browser#1838

UI implementation: brave/brave-ui#248

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • click on BAT logo
  • click join button
  • make sure that waiting button has en test

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original work done in brave/brave-ui#248 (approved and merged)

LGTM 😄 👍

@bsclifton bsclifton merged commit 991937f into master Oct 30, 2018
@bsclifton bsclifton deleted the hard-code branch October 30, 2018 05:59
bsclifton added a commit that referenced this pull request Oct 30, 2018
Adds hard coded text for welcome panel
bsclifton added a commit that referenced this pull request Oct 30, 2018
Adds hard coded text for welcome panel
@bsclifton
Copy link
Member

master 991937f
0.57.x 12226c0
0.56.x 4b0d338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing BRAVEREWARDSCREATINGTEXT string on Rewards Panel
3 participants