-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing BRAVEREWARDSCREATINGTEXT string on Rewards Panel #1838
Missing BRAVEREWARDSCREATINGTEXT string on Rewards Panel #1838
Comments
we need to generate new translations files |
Transifex was moved to C71 strings and we can't maintain multiple transifex's. So you'll have to work around that in some way @NejcZdovc |
0.56.x must remain on C70. |
ok will just copy en string to all files. wdyt? @bbondy |
Issue doesn't seem to be fixed on all platforms. @kjozwiak reproduced on macOS and Windows:
|
cc @bbondy for help |
Original work should be reverted and put in dev channel. |
Verified passed with
Verification Passed on
Verification Passed on
|
Steps to Reproduce
Actual result:
Reproduces how often:
always
Brave version (brave://version info)
Reproducible on current release:
No
There is no waiter message in Rewards Panel on Release build.
@srirambv @GeetaSarvadnya @kjozwiak @LaurenWags @NejcZdovc @ryanml
The text was updated successfully, but these errors were encountered: