Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing BRAVEREWARDSCREATINGTEXT string on Rewards Panel #1838

Closed
btlechowski opened this issue Oct 25, 2018 · 8 comments · Fixed by brave/brave-core#735 or brave/brave-core#766
Closed

Comments

@btlechowski
Copy link

btlechowski commented Oct 25, 2018

Steps to Reproduce

  1. Clean install
  2. Open Rewards Panel
  3. Click Join Rewards
  4. Observe the Join Rewards Button to be transformed into Waiter message (enabling Rewards from panel should have waiter message when opting in #1502)

Actual result:

image

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.56.6 Chromium: 70.0.3538.67 (Official Build) beta (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

Reproducible on current release:

No
There is no waiter message in Rewards Panel on Release build.

@srirambv @GeetaSarvadnya @kjozwiak @LaurenWags @NejcZdovc @ryanml

@NejcZdovc
Copy link
Contributor

we need to generate new translations files

@bbondy
Copy link
Member

bbondy commented Oct 25, 2018

Transifex was moved to C71 strings and we can't maintain multiple transifex's. So you'll have to work around that in some way @NejcZdovc

@bbondy
Copy link
Member

bbondy commented Oct 25, 2018

0.56.x must remain on C70.

@NejcZdovc
Copy link
Contributor

ok will just copy en string to all files. wdyt? @bbondy

@srirambv
Copy link
Contributor

srirambv commented Oct 26, 2018

Issue doesn't seem to be fixed on all platforms. @kjozwiak reproduced on macOS and Windows:

  • Win 10 x64 - Still reproducible
  • macOS 10.13.6 x64 - still reproducible
  • Linux - still reproducible

1838

@srirambv srirambv reopened this Oct 26, 2018
@NejcZdovc
Copy link
Contributor

cc @bbondy for help

@bbondy
Copy link
Member

bbondy commented Oct 27, 2018

Original work should be reverted and put in dev channel.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 31, 2018

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

screen shot 2018-10-31 at 4 47 54 pm

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment