Splited p3a from crash report option from first run dialog

[simonhong]

p3a prefs would not be affected by first run dialog.
crash report checkbox is unchecked by default.

fix brave/brave-browser#14183
fix brave/brave-browser#14160

Resolves

Submitter Checklist:

• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)
• Requested a security/privacy review as needed

Reviewer Checklist:

• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Launch with clean profile
2. Check crash report checkbox is un-checked by default
3. Check settings reflects properly for crash report checkbox state
4. Check crash report checkbox state doesn't affect p3a prefs state

[iefremov]

I recall we were thinking about different wording for crash reports, like "if things go wrong" or something :)

[karenkliu]

@iefremov I remember that too! No one proposed the official alternate string in the spec though so I left it as is.

[karenkliu]

Looks great Simon! 👍

[mkarolin]

chromium_src changes LGTM.

[kjozwiak]

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
--- | ---
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | macOS Version 11.1 (Build 20C69)

Test Case #1 (leaving crash report unchecked)

• launched 1.22.39 CR: 89.0.4389.58 and ensured that Help improve Brave by automatically sending crash reports was not being selected by default
• ensured that Automatically send completely private product analytics to Brave was enabled via brave://settings/privacy
• ensured that Help improve Brave's features and performance was disabled
• crashed Brave via brave://crash and ensured that the crash report appeared under brave://crashes but wasn't submitted
• ensured that restarting Brave didn't submit the crash report via brave://crashes
• ensured that clicking on Send now under brave://crashes sends the crash report to BackTrace
• ensured that P3A is working/being updated via brave://local-state

Example	Example	Example

Test Case #2 (leaving crash report selected)

• launched 1.22.39 CR: 89.0.4389.58 and ensured that Help improve Brave by automatically sending crash reports was not being selected by default
• selected Help improve Brave by automatically sending crash reports and clicked on Start Brave
• ensured that Automatically send completely private product analytics to Brave was enabled via brave://settings/privacy
• ensured that Help improve Brave's features and performance was enabled via brave://settings/privacy
• crashed Brave via brave://crash and ensured that the crash report appeared under brave://crashes and was automatically submitted
• ensured that P3A is working/being updated via brave://local-state

Example	Example	Example

Test Case #3 (Onboarding)

• ensured that clicking on completely private product analytics opens the following:
  • https://brave.com/privacy-preserving-product-analytics-p3a/
• ensured that Settings opens brave://settings/privacy