Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic PPA is enabled when it was disabled on first run dialog #14160

Closed
btlechowski opened this issue Feb 15, 2021 · 3 comments · Fixed by brave/brave-core#7978
Closed

Automatic PPA is enabled when it was disabled on first run dialog #14160

btlechowski opened this issue Feb 15, 2021 · 3 comments · Fixed by brave/brave-core#7978
Assignees
@simonhong
Labels
design A design change, especially one which needs input from the design team OS/Desktop OS/Linux OS/macOS QA Pass-Linux QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.21.x - Release

Comments

@btlechowski
Copy link

Follow up to #12679.
The dialog states:

Help improve Brave by sending crash reports and completely anonymised, private product analytics.

image

Yet Automatically send completely private product analytics to Brave is enabled in brave://settings/privacy.
@karenkliu is this expected?

The figma in https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/?node-id=146%3A0 states that only Help improve Brave's features and performance is to be disabled or enabled based on the toggle state.

Steps to Reproduce

  1. Clean profile
  2. Run Browser
  3. Disable Help improve Brave by sending crash reports and completely anonymised, private product analytics.
  4. Open brave://settings/privacy

Note: Help improve Brave's features and performance is properly disabled

Actual result:

Automatically send completely private product analytics to Brave is enabled in brave://settings/privacy
image

Expected result:

Automatically send completely private product analytics to Brave is disabled in brave://settings/privacy

Reproduces how often:

100% repro

Brave version (brave://version info)

Brave 1.21.47 Chromium: 88.0.4324.152 (Official Build) beta (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
Brave 1.22.23 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @karenkliu @rebron
@btlechowski btlechowski added OS/Linux OS/macOS QA/Yes release-notes/exclude QA/Test-Plan-Specified OS/Desktop design A design change, especially one which needs input from the design team labels Feb 15, 2021
@btlechowski btlechowski mentioned this issue Feb 15, 2021
Closed
@btlechowski
Copy link
Author

@simonhong This issue will fixed when #14183 will be implemented.

@simonhong simonhong self-assigned this Feb 17, 2021
@simonhong simonhong mentioned this issue Feb 17, 2021
Merged
23 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 17, 2021
@simonhong
Splited p3a from crash report option from first run dialog
3c6abb0 
p3a prefs would not be affected by first run dialog.
crash report checkbox is unchecked by default.

fix brave/brave-browser#14183
fix brave/brave-browser#14160
@simonhong simonhong added this to the 1.22.x - Nightly milestone Feb 18, 2021
@brave-builds brave-builds mentioned this issue Feb 18, 2021
Merged
7 tasks
@LaurenWags
Copy link
Member

Removing QA/Blocked as https://github.com/brave/brave-browser/releases/tag/v1.21.68 is available

@stephendonner
Copy link

stephendonner commented Feb 25, 2021 •
edited by btlechowski
Loading

Verified FIXED on 1.21.68 using:

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)

See #14183 (comment) for full steps and screenshots, which apply here.

Verified:

  • P3A and crash-reporting prefs are split out, separately
  • in the first-run modal dialog, Help improve Brave by automatically sending crash reports is unchecked by default, and has no bearing on the below:
  • Automatically send completely private product analytics to Brave is checked by default in brave://settings/privacy - this is opt-out

Verification passed on

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Ubuntu 18.04 LTS

image

Verified P3A and crash-reporting prefs are split out, separately
Verified in the first-run modal dialog, Help improve Brave by automatically sending crash reports is unchecked by default, and has only bearing on Help improve Brave's features and performance in brave://settings/privacy
Verified Automatically send completely private product analytics to Brave in brave://settings/privacy is checked by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
design A design change, especially one which needs input from the design team OS/Desktop OS/Linux OS/macOS QA Pass-Linux QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging a pull request may close this issue.

Splited p3a from crash report option from first run dialog brave/brave-core
5 participants
@stephendonner @kjozwiak @simonhong @LaurenWags @btlechowski