Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest saved page always from wayback machine by invalidating callback params #8376

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 29, 2021

fix brave/brave-browser#14991

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter=BraveWaybackMachineUtilsTest.*

  1. Launch browser and load https://brave.com/hackerone/?lkasjdf=asldjflakjsf&callback=%7B%22archived_snapshots%22%3A%7B%22closest%22%3A%7B%22url%22%3A%22https%3A%2F%2Fexample.com%2Ffavicon.ico%22%7D%7D%7D%2F%2F
  2. Try saved version from wayback machine
  3. Check brave doesn't redirect to https://example.com/favicon.ico

@simonhong simonhong self-assigned this Mar 29, 2021
@simonhong
Copy link
Member Author

Merged because only BraveNavigatorUserAgentFarblingBrowserTest.FarbleNavigatorUserAgent is failed on macOS.
and it's reported already.

@simonhong simonhong merged commit 7d31c91 into master Mar 30, 2021
@simonhong simonhong deleted the waybackmachine_url_fixup branch March 30, 2021 00:24
@simonhong simonhong added this to the 1.24.x - Nightly milestone Mar 31, 2021
samartnik pushed a commit to samartnik/brave-core that referenced this pull request Apr 5, 2021
Exclude unit tests from upstream that are known to fail in Brave
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] [hackerone] wayback machine callback
2 participants