Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support of Unstoppable Domains and ENS on Android #8520

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Apr 13, 2021

Resolves brave/brave-browser#15159
Resolves brave/brave-browser#15373

Screenshot_20210415-192044

Screenshot_20210415-191948

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open settings ->Privacy & Security -> Unstoppable Domains, the settings should be Ask.
  2. Visit brad.crypto, interstitial page for opting in should be shown, click Disable.
  3. Go to settings ->Privacy & Security -> Unstoppable Domains, the settings should be Disabled.
  4. Change it back to Ask.
  5. Visit brad.crypto again, and click Proceed this time in the interstitial page.
  6. Page should be loaded and setting should be changed to DNS over HTTPS.
    Repeat 1-6 but using almonit.eth this time.
  7. Go to settings ->Privacy & Security -> Unstoppable Domains, set to Ethereum
  8. Visit brave.crypto, the page should be redirected and loaded via IPFS public gateway.

@yrliou yrliou added this to the 1.25.x - Nightly milestone Apr 13, 2021
@yrliou yrliou requested a review from a team as a code owner April 13, 2021 05:35
@yrliou yrliou self-assigned this Apr 13, 2021
@yrliou yrliou changed the title Enable support of Unstoppable Domains and ENS via DoH on Android Enable support of Unstoppable Domains and ENS on Android Apr 16, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src change ++

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.35 x64 nightly build

  • Verified test plan from PR description
  • Verified default setting is set to Ask for UD
  • Verified visiting brad.crypto shows interstitial page
  • Verified Proceed using Cloudflare loads the page
  • Verified setting is set to DoH once the page is loaded
  • Verified setting UD to Ethereum and visiting brave.crypto loads the page via public IFPS gateway
Screenshots

Settings

Default (Ask) Denied DNS over HTTPS Etherem
image image image image

Page Loads

Interstitial page Page loaded successfully (DoH) Page load failed (Denied) Page loaded via IPFS public gateway
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Support Unstoppable Domains via Ethereum Support Unstoppable Domains and ENS on Android via DoH
4 participants