Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support permission lifetime options for "Block" decision. (uplift to 1.25.x) #8733

Merged
merged 1 commit into from
May 10, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 6, 2021

Uplift of #8693
Resolves brave/brave-browser#15603

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from goodov and a team as code owners May 6, 2021 18:30
@brave-builds brave-builds requested a review from a team May 6, 2021 18:30
@brave-builds brave-builds self-assigned this May 6, 2021
@brave-builds brave-builds added this to the 1.25.x - Beta milestone May 6, 2021
@kjozwiak
Copy link
Member

kjozwiak commented May 9, 2021

post-init failed due to audit-deps warnings as per https://ci.brave.com/job/pr-brave-browser-pr8693_issues-15603_1.25.x-post-init/1/execution/node/144/log/. However, these are known warning/issues and unrelated to this specific PR.

Restarting macOS due to timing out after the 6hr limit was reached as per https://ci.brave.com/job/pr-brave-browser-pr8693_issues-15603_1.25.x-macos/1/console.

0:37:48  Cancelling nested steps due to timeout
20:37:48  Sending interrupt signal to process
20:37:48  [353/7957] CXX obj/services/device/public/cpp/test_support/fake_serial_port_client.o
20:37:48  Sending interrupt signal to process
20:37:48  ninja: build stopped: interrupted by user.
[Pipeline] }
[Pipeline] // timeout
Post stage
[Pipeline] junit
20:37:49  Recording test results
20:37:49  No test report files were found. Configuration error?
Error when executing always post condition:
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to mac-mini2-sf
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1800)
		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
		at hudson.remoting.Channel.call(Channel.java:1001)
		at hudson.FilePath.act(FilePath.java:1166)
		at hudson.FilePath.act(FilePath.java:1155)
		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:107)
		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:149)
		at hudson.tasks.junit.JUnitResultArchiver.parseAndSummarize(JUnitResultArchiver.java:243)
		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:63)
		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:29)
		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
		at java.base/java.lang.Thread.run(Thread.java:834)
hudson.AbortException: No test report files were found. Configuration error?
	at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:152)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3328)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8693 (comment).

@kjozwiak kjozwiak merged commit eb123e6 into 1.25.x May 10, 2021
@kjozwiak kjozwiak deleted the pr8693_issues/15603_1.25.x branch May 10, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants