Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sync this device option #913

Merged
merged 2 commits into from
Nov 16, 2018
Merged

remove sync this device option #913

merged 2 commits into from
Nov 16, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Nov 15, 2018

closes brave/brave-browser#2156

user can clear the group if they want to turn it off so no need to have this.
this is per design request.

Test Plan:

should not see this

screen shot 2018-11-14 at 9 00 50 pm

and see this

screen shot 2018-11-15 at 4 55 36 pm

npm run test-unit should pass

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to remove SyncUIDOMHandler::SyncThisDevice from handling syncThisDevice in browser/ui/webui/sync/sync_ui.cc

@cezaraugusto cezaraugusto merged commit b5cb062 into master Nov 16, 2018
@cezaraugusto cezaraugusto deleted the cez-sync-remove-device branch November 16, 2018 01:57
cezaraugusto added a commit that referenced this pull request Nov 16, 2018
cezaraugusto added a commit that referenced this pull request Nov 16, 2018
@cezaraugusto
Copy link
Contributor Author

master b5cb062
0.58.x 25a87a3
0.57.x b9eb745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove sync this device interface
4 participants