Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedreader: Fix icon onclick in reader mode state #9393

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Jul 9, 2021

Clicking the pill should refresh the page (thus toggling the
distillation off). The promo bubble is only shown automatically, the
first 3 times that Speedreader is used. This was brought up in
Friday's design review

Resolves brave/brave-browser#16888

Clicking the pill should refresh the page (thus toggling the
distillation off). The promo bubble is only shown automatically, the
first 3 times that Speedreader is used.

Resolves brave/brave-browser#16888
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkuehlz kkuehlz merged commit 3e27033 into master Jul 12, 2021
@kkuehlz kkuehlz deleted the fix_reader_mode_pill_onclick branch July 12, 2021 07:14
@kkuehlz kkuehlz added this to the 1.29.x - Nightly milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speedreader: clicking reader mode pill should toggle off the page
2 participants