Speedreader change icon behavior #9396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkuehlz
commented
Jul 10, 2021
iefremov
reviewed
Jul 11, 2021
iefremov
approved these changes
Jul 11, 2021
simonhong
approved these changes
Jul 12, 2021
added 3 commits
July 12, 2021 00:18
After a meeting with the Speedreader team, Raf suggested we have too much going on in the omnibox, and that we ought to kill the labels. Instead of indicating page state via labels, we do so with different icons. Icon vector change is triggered from the Update() method. We get to delete lots of code now that we don't need to bother with labels :) Resolves brave/brave-browser#9262
In 85a5f8b we removed the label from the Speedreader icon. To make up for this, we need more descriptive accessible text. This is taken from the figma document linked in the issue. Resolves brave/brave-browser#16881
kkuehlz
force-pushed
the
speedreader_change_icon_behavior
branch
from
7b25be4
to
ab1af8e
Compare
|
Test failures fixed in #9400. Unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16881, brave/brave-browser#9262
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: