Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix speedreader accessible text #16881

Closed
kkuehlz opened this issue Jul 9, 2021 · 0 comments · Fixed by brave/brave-core#9396
Closed

Fix speedreader accessible text #16881

kkuehlz opened this issue Jul 9, 2021 · 0 comments · Fixed by brave/brave-core#9396
Assignees
@kkuehlz
Labels
feature/speedreader OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.28.x - Release

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 9, 2021

Right now the accessible text is placeholder taken from Chromium. Use Additional States and Dark Theme section from Figma.

https://www.figma.com/file/YHMNRL2XpZDOUe6n1Dw6K1/Desktop-Speedreader?node-id=0%3A1
@kkuehlz kkuehlz changed the title Apply spec for additional states and dark theme to Speedreader Fix speedreader accessible text Jul 9, 2021
@kkuehlz kkuehlz self-assigned this Jul 9, 2021
@kkuehlz kkuehlz added feature/speedreader priority/P3 The next thing for us to work on. It'll ride the trains. QA/No OS/Desktop labels Jul 9, 2021
@kkuehlz kkuehlz mentioned this issue Jul 9, 2021
Closed
kkuehlz pushed a commit to brave/brave-core that referenced this issue Jul 10, 2021
speedreader: icon: Fix accessible text
7b25be4 
In 85a5f8b we removed the label from the Speedreader icon. To make up
for this, we need more descriptive accessible text. This is taken from
the figma document linked in the issue.

Resolves brave/brave-browser#16881
@kkuehlz kkuehlz mentioned this issue Jul 10, 2021
Merged
24 tasks
kkuehlz pushed a commit to brave/brave-core that referenced this issue Jul 12, 2021
speedreader: icon: Fix accessible text
1256137 
In 85a5f8b we removed the label from the Speedreader icon. To make up
for this, we need more descriptive accessible text. This is taken from
the figma document linked in the issue.

Resolves brave/brave-browser#16881
@kkuehlz kkuehlz added this to the 1.28.x - Nightly milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkuehlz kkuehlz

Labels
feature/speedreader OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Speedreader change icon behavior brave/brave-core
1 participant
@kkuehlz