Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the speedreader promo bubble #9262

Closed
iefremov opened this issue Apr 16, 2020 · 6 comments
Closed

Implement the speedreader promo bubble #9262

iefremov opened this issue Apr 16, 2020 · 6 comments

Comments

@iefremov
Copy link
Contributor

iefremov commented Apr 16, 2020

Description

Introduce users to Speedreader.

Design

User Flow

A fresh Brave Browser install supports reader mode by default. Users will see a reader mode icon when visiting a reader-mode available page. Clicking on it for the first time will show a promo tooltip to turn on Speedreader. This promo tooltip appears 3 total times, regardless of whether or not the user has turned on Speedreader before. The user can ignore the tooltip and continue using reader mode normally; clicking the "Reader Mode" pill in the URL bar will turn off Reader Mode as the user expects.

If the user clicks "Turn on Speedreader" in the promo tooltip, this will turn on Speedreader globally. Users visiting a speedreader page will see it automatically load in Speedreader. The user can click on the "Speedreader" pill in the URL bar to turn off Speedreader view for just that domain. This does not change the behavior of readable pages being automatically loaded in Speedreader. Users can turn off Speedreader globally by visiting brave://settings and toggling it off. This will revert Brave to using the default reader mode.

Group 47

Settings

image

Additional interaction states and dark theme

Group 48

Notes

Speedreader and its introductory experience with the promo tooltip is per browser profile.

Assets

Figma link: https://www.figma.com/file/YHMNRL2XpZDOUe6n1Dw6K1/?node-id=0%3A1

@iefremov iefremov self-assigned this Apr 16, 2020
@rebron rebron added OS/Desktop QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels May 22, 2020
@srirambv srirambv changed the title Implement the speedreader promo bubble [Desktop] Implement the speedreader promo bubble Sep 9, 2020
@iefremov iefremov removed their assignment May 19, 2021
@karenkliu
Copy link

@keur Updated this with latest designs for you!

@iefremov
Copy link
Contributor Author

iefremov commented Jun 3, 2021

@karenkliu for some reason dismissing the tooltip on the diagram leads to "Reader Mode ON", perhaps this is not intentional?

@karenkliu
Copy link

@iefremov It's intentional; the user sees the promo tooltip for Speedreader only after they have already turned on the normal Reader mode. I can provide a walkthrough of the UX if that helps!

@karenkliu
Copy link

Re: today's discussion. The Speedreader promo bubble has been implemented, but needs to show the first 3 times the user turns on Reader Mode. It should not be triggered when user clicks on the Reader mode icon (this should only toggle on/off Reader mode).

@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 9, 2021

Created a separate issue for the accessible text. Going to batch these fixes into the same PR thoough

#16881

kkuehlz pushed a commit to brave/brave-core that referenced this issue Jul 10, 2021
After a meeting with the Speedreader team, Raf suggested we have too
much going on in the omnibox, and that we ought to kill the labels.
Instead of indicating page state via labels, we do so with different
icons. Icon vector change is triggered from the Update() method.

We get to delete lots of code now that we don't need to bother with
labels :)

Resolves brave/brave-browser#9262
@kkuehlz kkuehlz added this to the 1.28.x - Nightly milestone Jul 14, 2021
@stephendonner
Copy link

stephendonner commented Jul 27, 2021

Verified PASSED following the inline testplan here with build

Brave 1.28.91 Chromium: 92.0.4515.107 (Official Build) beta (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 11.5.1 (Build 20G80)

Confirmed:

  • clicking on the Speedreader icon shows the promo tooltip
  • after clicking again and then again (3x total), the Speedreader promo tooltip no longer pops up
  • after clicking Turn on Speedreader via the promo tooltip, all supported text articles automatically load in Speedreader mode, until explicitly disabled (either globally via brave://settings or the icon in the URL bar)
  • after clicking the promo Turn on Speedreader tooltip, above, confirmed Speedreader is toggled to On via brave://settings/
  • after clicking to toggle Speedreader to Off in brave://settings/, loaded a few sites, and confirmed they returned to default (non-Speedreader/reader) mode
  • after globally enabling Speedreader, then visiting nytimes.com and clicking on an article, I was in Speedreader mode. Toggling the Speedreader icon to Off via the www.nytimes.com in Speedreader toggle, the site now refreshed and was back in default mode
  • after clicking to get and then dismissing the Turn on Speedreader promo tooltip 3x, I'm able to toggle the Reader mode on/off via its icon in the URL bar
  • light and dark modes were tested
  • Speedreader works in private windows, private windows with Tor, and Guest mode
  • confirmed the tooltip for Speedreader mode is Speedreader settings
example example example example example example example example example
Screen Shot 2021-07-26 at 5 24 52 PM Screen Shot 2021-07-26 at 5 25 11 PM Screen Shot 2021-07-26 at 5 41 36 PM Screen Shot 2021-07-26 at 5 41 52 PM Screen Shot 2021-07-26 at 5 21 08 PM Screen Shot 2021-07-26 at 5 36 48 PM Screen Shot 2021-07-26 at 5 55 24 PM Screen Shot 2021-07-26 at 5 55 46 PM Screen Shot 2021-07-26 at 5 56 09 PM

Verification passed on

Brave 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Ubuntu 18.04 LTS

Confirmed:

  • clicking on the Speedreader icon shows the promo tooltip
  • after clicking again and then again (3x total), the Speedreader promo tooltip no longer pops up
  • after clicking Turn on Speedreader via the promo tooltip, all supported text articles automatically load in Speedreader mode, until explicitly disabled (either globally via brave://settings or the icon in the URL bar)
  • after clicking the promo Turn on Speedreader tooltip, above, confirmed Speedreader is toggled to On via brave://settings/
  • after clicking to toggle Speedreader to Off in brave://settings/, loaded a few sites, and confirmed they returned to default (non-Speedreader/reader) mode
  • after globally enabling Speedreader, then visiting nytimes.com and clicking on an article, I was in Speedreader mode. Toggling the Speedreader icon to Off via the www.nytimes.com in Speedreader toggle, the site now refreshed and was back in default mode
  • after clicking to get and then dismissing the Turn on Speedreader promo tooltip 3x, I'm able to toggle the Reader mode on/off via its icon in the URL bar
  • light and dark modes were tested
  • Speedreader works in private windows, private windows with Tor, and Guest mode
  • confirmed the tooltip for Speedreader mode is Speedreader settings

Light theme

image image image image

Dark theme

image image image image

Logged #17216


Verification passed on

Brave | 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | Windows 10 OS Version 2004 (Build 19041.1110)

Confirmed:

  • clicking on the Speedreader icon shows the promo tooltip
  • after clicking again and then again (3x total), the Speedreader promo tooltip no longer pops up
  • after clicking Turn on Speedreader via the promo tooltip, all supported text articles automatically load in Speedreader mode, until explicitly disabled (either globally via brave://settings or the icon in the URL bar)
  • after clicking the promo Turn on Speedreader tooltip, above, confirmed Speedreader is toggled to On via brave://settings/
  • after clicking to toggle Speedreader to Off in brave://settings/, loaded a few sites, and confirmed they returned to default (non-Speedreader/reader) mode
  • after globally enabling Speedreader, then visiting nytimes.com and clicking on an article, I was in Speedreader mode. Toggling the Speedreader icon to Off via the www.nytimes.com in Speedreader toggle, the site now refreshed and was back in default mode
  • after clicking to get and then dismissing the Turn on Speedreader promo tooltip 3x, I'm able to toggle the Reader mode on/off via its icon in the URL bar
  • light and dark modes were tested
  • Speedreader works in private windows, private windows with Tor, and Guest mode
  • confirmed the tooltip for Speedreader mode is Speedreader settings

Light theme

example example example example example example example
image image image image image image image

Dark theme

example example example example example example example
image image image image image image image

@rebron rebron changed the title [Desktop] Implement the speedreader promo bubble Implement the speedreader promo bubble Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants