-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the speedreader promo bubble #9262
Comments
@keur Updated this with latest designs for you! |
@karenkliu for some reason dismissing the tooltip on the diagram leads to "Reader Mode ON", perhaps this is not intentional? |
@iefremov It's intentional; the user sees the promo tooltip for Speedreader only after they have already turned on the normal Reader mode. I can provide a walkthrough of the UX if that helps! |
Re: today's discussion. The Speedreader promo bubble has been implemented, but needs to show the first 3 times the user turns on Reader Mode. It should not be triggered when user clicks on the Reader mode icon (this should only toggle on/off Reader mode). |
Created a separate issue for the accessible text. Going to batch these fixes into the same PR thoough |
After a meeting with the Speedreader team, Raf suggested we have too much going on in the omnibox, and that we ought to kill the labels. Instead of indicating page state via labels, we do so with different icons. Icon vector change is triggered from the Update() method. We get to delete lots of code now that we don't need to bother with labels :) Resolves brave/brave-browser#9262
Verified
Confirmed:
Verification passed on
Confirmed:
Light theme Dark theme Logged #17216 Verification passed on
Confirmed:
Light theme
Dark theme
|
Description
Introduce users to Speedreader.
Design
User Flow
A fresh Brave Browser install supports reader mode by default. Users will see a reader mode icon when visiting a reader-mode available page. Clicking on it for the first time will show a promo tooltip to turn on Speedreader. This promo tooltip appears 3 total times, regardless of whether or not the user has turned on Speedreader before. The user can ignore the tooltip and continue using reader mode normally; clicking the "Reader Mode" pill in the URL bar will turn off Reader Mode as the user expects.
If the user clicks "Turn on Speedreader" in the promo tooltip, this will turn on Speedreader globally. Users visiting a speedreader page will see it automatically load in Speedreader. The user can click on the "Speedreader" pill in the URL bar to turn off Speedreader view for just that domain. This does not change the behavior of readable pages being automatically loaded in Speedreader. Users can turn off Speedreader globally by visiting brave://settings and toggling it off. This will revert Brave to using the default reader mode.
Settings
Additional interaction states and dark theme
Notes
Speedreader and its introductory experience with the promo tooltip is per browser profile.
Assets
Figma link: https://www.figma.com/file/YHMNRL2XpZDOUe6n1Dw6K1/?node-id=0%3A1
The text was updated successfully, but these errors were encountered: